linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* inotify_unmount_inodes badness?
@ 2009-03-11  3:46 Nick Piggin
  0 siblings, 0 replies; only message in thread
From: Nick Piggin @ 2009-03-11  3:46 UTC (permalink / raw)
  To: linux-fsdevel


inotify_unmount_inodes does this hairly looking thing with
list_for_each_entry_safe, where it tries to take a reference
to the "next" inode as well as the current, before dropping
inode_lock. But it doesn't take a reference on inodes without
a refcount, or I_CLEAR|I_FREEING|I_WILL_FREE inodes before
dropping the lock. Can't these guys just go away at any time?

Why does it need the safe list traveral anyway (which is causing
this complexity)? We don't remove the inode from its sb list
here, do we??


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2009-03-11  3:46 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-11  3:46 inotify_unmount_inodes badness? Nick Piggin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).