From: Christoph Hellwig <hch@infradead.org>
To: Sage Weil <sage@newdream.net>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, viro@zeniv.linux.org.uk,
adilger@sun.com
Subject: Re: [PATCH] vfs: make real_lookup do dentry revalidation with i_mutex held
Date: Thu, 19 Mar 2009 15:32:49 -0400 [thread overview]
Message-ID: <20090319193249.GA23267@infradead.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0903170957560.18956@cobra.newdream.net>
On Tue, Mar 17, 2009 at 10:03:35AM -0700, Sage Weil wrote:
> On Tue, 17 Mar 2009, Christoph Hellwig wrote:
> > Keeping i_mutes over do_revalidate seem fine from a first glance, but
> > can you please do it without rearranging the whole code?
>
> Yeah, but not without an extra goto. Holding i_mutex over revalidate is
> only half of it... we also want to go ahead with the ->lookup if the
> revalidate fails (instead of returning -ENOENT). I make the patch easier
> to read (with a goto), but I assumed we'd want the resulting code to be
> more clear?
Well, if you want to re-organize real_lookup make that a separate patch.
Might actually be worthwile to do so and clean up the other issues
in there (too long line in the prototype, spaces after the pointer *,
too. And then have a small patch ontop to implement the mutex and
going ahead with the lookup.
next prev parent reply other threads:[~2009-03-19 19:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-09 18:31 [PATCH] vfs: make real_lookup do dentry revalidation with i_mutex held Sage Weil
2009-03-10 19:22 ` Miklos Szeredi
2009-03-10 19:31 ` Sage Weil
2009-03-17 8:17 ` Christoph Hellwig
2009-03-17 17:03 ` Sage Weil
2009-03-19 19:32 ` Christoph Hellwig [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-09-24 16:10 Sage Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090319193249.GA23267@infradead.org \
--to=hch@infradead.org \
--cc=adilger@sun.com \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sage@newdream.net \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).