From: Nick Piggin <npiggin@suse.de>
To: viro@zeniv.linux.org.uk
Cc: "Jorge Boncompte [DTI2]" <jorge@dti2.net>,
linux-fsdevel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: [patch] fs: add a remount,ro coherency point
Date: Mon, 30 Mar 2009 13:33:54 +0200 [thread overview]
Message-ID: <20090330113354.GC31000@wotan.suse.de> (raw)
fs: invalidate sb->s_bdev on remount,ro
Fixes a problem reported by "Jorge Boncompte [DTI2]" <jorge@dti2.net>
who is trying to snapshot a minix filesystem image.
Signed-off-by: Nick Piggin <npiggin@suse.de>
---
fs/super.c | 8 ++++++++
1 file changed, 8 insertions(+)
Index: linux-2.6/fs/super.c
===================================================================
--- linux-2.6.orig/fs/super.c
+++ linux-2.6/fs/super.c
@@ -647,6 +647,14 @@ int do_remount_sb(struct super_block *sb
acct_auto_close(sb);
shrink_dcache_sb(sb);
fsync_super(sb);
+ /* Some filesystems modify their metadata via some other path
+ than the bdev buffer cache (eg. use a private mapping, or
+ directories in pagecache, etc). Also file data modifications
+ go via their own mappings. So If we try to mount readonly
+ then copy the filesystem from bdev, we could get stale data,
+ so invalidate it to give a best effort at coherency. */
+ if (flags & MS_RDONLY && sb->s_bdev)
+ invalidate_bdev(sb->s_bdev);
/* If we are remounting RDONLY and current sb is read/write,
make sure there are no rw files opened */
next reply other threads:[~2009-03-30 11:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-30 11:33 Nick Piggin [this message]
2009-03-30 12:19 ` [patch] fs: add a remount,ro coherency point Jorge Boncompte [DTI2]
2009-03-30 12:55 ` Wu Fengguang
2009-03-30 13:09 ` Nick Piggin
2009-03-30 13:22 ` Wu Fengguang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090330113354.GC31000@wotan.suse.de \
--to=npiggin@suse.de \
--cc=akpm@linux-foundation.org \
--cc=jorge@dti2.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).