From: Al Viro <viro@ZenIV.linux.org.uk>
To: Dmitri Vorobiev <dmitri.vorobiev@movial.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
tytso@mit.edu, adilger@sun.com, linux-ext4@vger.kernel.org,
alex@clusterfs.com, aneesh.kumar@linux.vnet.ibm.com
Subject: Re: [PATCH] Remove two unneeded exports and make two symbols static in fs/mpage.c
Date: Wed, 1 Apr 2009 12:39:34 +0100 [thread overview]
Message-ID: <20090401113934.GB28946@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1238449280-10318-1-git-send-email-dmitri.vorobiev@movial.com>
On Tue, Mar 31, 2009 at 12:41:20AM +0300, Dmitri Vorobiev wrote:
> Commit 29a814d2ee0e43c2980f33f91c1311ec06c0aa35 (vfs: add hooks for
> ext4's delayed allocation support) exported the following functions
>
> mpage_bio_submit()
> __mpage_writepage()
>
> for the benefit of ext4's delayed allocation support. Since commit
> a1d6cc563bfdf1bf2829d3e6ce4d8b774251796b (ext4: Rework the
> ext4_da_writepages() function), these functions are not used by the
> ext4 driver anymore. However, the now unnecessary exports still
> remain, and this patch removes those. Moreover, these two functions
> can become static again.
>
> The issue was spotted by namespacecheck.
>
> Signed-off-by: Dmitri Vorobiev <dmitri.vorobiev@movial.com>
Applied.
prev parent reply other threads:[~2009-04-01 11:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-30 21:41 [PATCH] Remove two unneeded exports and make two symbols static in fs/mpage.c Dmitri Vorobiev
2009-03-31 4:38 ` Aneesh Kumar K.V
2009-04-01 11:39 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090401113934.GB28946@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=adilger@sun.com \
--cc=alex@clusterfs.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=dmitri.vorobiev@movial.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).