From mboxrd@z Thu Jan  1 00:00:00 1970
From: Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: [PATCH 1/4] VFS: Add a VFS helper function
	vfs_remote_path_lookup()
Date: Sun, 5 Apr 2009 03:25:41 +0100
Message-ID: <20090405022541.GA26366@ZenIV.linux.org.uk>
References: <20090402195759.GL28946@ZenIV.linux.org.uk> <alpine.LFD.2.00.0904021312560.4130@localhost.localdomain> <20090402202846.GM28946@ZenIV.linux.org.uk> <1238705130.16087.58.camel@heimdal.trondhjem.org> <20090402205418.GN28946@ZenIV.linux.org.uk> <1238710585.31262.28.camel@heimdal.trondhjem.org> <20090402231859.GP28946@ZenIV.linux.org.uk> <20090403010954.GQ28946@ZenIV.linux.org.uk> <20090403015220.GS28946@ZenIV.linux.org.uk> <1238786035.17533.52.camel@heimdal.trondhjem.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	linux-fsdevel@vger.kernel.org
To: Trond Myklebust <Trond.Myklebust@netapp.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from zeniv.linux.org.uk ([195.92.253.2]:58233 "EHLO
	ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755340AbZDECZr (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Sat, 4 Apr 2009 22:25:47 -0400
Content-Disposition: inline
In-Reply-To: <1238786035.17533.52.camel@heimdal.trondhjem.org>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Fri, Apr 03, 2009 at 03:13:55PM -0400, Trond Myklebust wrote:

> You have a potential problem in the case of do_filp_open(). It calls
> do_path_lookup(), but then expects to be able to reuse the same
> nameidata structure in subsequent calls to __do_follow_link().

Nothing potential about it.  I'll push fixes for that and a couple of
other nasties in a bit; sorry about disappearing, zeniv had been down
last night ;-/