From: Jeff Layton <jlayton@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-cifs-client@lists.samba.org, linux-fsdevel@vger.kernel.org
Subject: Re: [linux-cifs-client] [PATCH 1/3] cifs: rename cifs_iget to cifs_root_iget
Date: Sun, 5 Apr 2009 09:54:53 -0400 [thread overview]
Message-ID: <20090405095453.5cacb856@tleilax.poochiereds.net> (raw)
In-Reply-To: <20090405134214.GA5773@infradead.org>
On Sun, 5 Apr 2009 09:42:14 -0400
Christoph Hellwig <hch@infradead.org> wrote:
> On Sun, Apr 05, 2009 at 09:09:19AM -0400, Jeff Layton wrote:
> > The current cifs_iget isn't suitable for anything but the root inode.
> > Rename it with a more appropriate name.
>
> And using it for the root inode is stupid, too as it can't be in cache.
>
> The root inode is the case where you can easily use new_inode.
>
Yep. We might want to just get rid of that eventually and move the IPC
stuff elsewhere. With the follow-on patches here, I think using iget
makes the code a little simpler so I'll leave this in place for now.
--
Jeff Layton <jlayton@redhat.com>
next prev parent reply other threads:[~2009-04-05 13:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-05 13:09 [PATCH 0/3] cifs: make posix codepaths handle hardlinks appropriately (RFC) Jeff Layton
2009-04-05 13:09 ` [PATCH 1/3] cifs: rename cifs_iget to cifs_root_iget Jeff Layton
2009-04-05 13:42 ` [linux-cifs-client] " Christoph Hellwig
2009-04-05 13:54 ` Jeff Layton [this message]
2009-04-05 13:09 ` [PATCH 2/3] cifs: add new cifs_iget_unix_basic function Jeff Layton
2009-04-08 17:05 ` [linux-cifs-client] " Christoph Hellwig
2009-04-10 13:18 ` Jeff Layton
2009-04-05 13:09 ` [PATCH 3/3] cifs: add cifs_iget_unix and have readdir codepath use it Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090405095453.5cacb856@tleilax.poochiereds.net \
--to=jlayton@redhat.com \
--cc=hch@infradead.org \
--cc=linux-cifs-client@lists.samba.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).