From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Layton Subject: Re: [linux-cifs-client] [PATCH 1/3] cifs: rename cifs_iget to cifs_root_iget Date: Sun, 5 Apr 2009 09:54:53 -0400 Message-ID: <20090405095453.5cacb856@tleilax.poochiereds.net> References: <1238936961-6979-1-git-send-email-jlayton@redhat.com> <1238936961-6979-2-git-send-email-jlayton@redhat.com> <20090405134214.GA5773@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: linux-cifs-client@lists.samba.org, linux-fsdevel@vger.kernel.org To: Christoph Hellwig Return-path: Received: from mx2.redhat.com ([66.187.237.31]:37515 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752234AbZDENzJ (ORCPT ); Sun, 5 Apr 2009 09:55:09 -0400 In-Reply-To: <20090405134214.GA5773@infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sun, 5 Apr 2009 09:42:14 -0400 Christoph Hellwig wrote: > On Sun, Apr 05, 2009 at 09:09:19AM -0400, Jeff Layton wrote: > > The current cifs_iget isn't suitable for anything but the root inode. > > Rename it with a more appropriate name. > > And using it for the root inode is stupid, too as it can't be in cache. > > The root inode is the case where you can easily use new_inode. > Yep. We might want to just get rid of that eventually and move the IPC stuff elsewhere. With the follow-on patches here, I think using iget makes the code a little simpler so I'll leave this in place for now. -- Jeff Layton