From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [linux-cifs-client] [PATCH 1/3] cifs: rename cifs_iget to cifs_root_iget Date: Sun, 5 Apr 2009 09:42:14 -0400 Message-ID: <20090405134214.GA5773@infradead.org> References: <1238936961-6979-1-git-send-email-jlayton@redhat.com> <1238936961-6979-2-git-send-email-jlayton@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-cifs-client@lists.samba.org, linux-fsdevel@vger.kernel.org To: Jeff Layton Return-path: Received: from bombadil.infradead.org ([18.85.46.34]:38446 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752756AbZDENmQ (ORCPT ); Sun, 5 Apr 2009 09:42:16 -0400 Content-Disposition: inline In-Reply-To: <1238936961-6979-2-git-send-email-jlayton@redhat.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sun, Apr 05, 2009 at 09:09:19AM -0400, Jeff Layton wrote: > The current cifs_iget isn't suitable for anything but the root inode. > Rename it with a more appropriate name. And using it for the root inode is stupid, too as it can't be in cache. The root inode is the case where you can easily use new_inode.