From: Wu Fengguang <fengguang.wu@intel.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Nick Piggin <npiggin@suse.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
Wu Fengguang <fengguang.wu@intel.com>
Cc: David Rientjes <rientjes@google.com>
Cc: Hugh Dickins <hugh@veritas.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Lee Schermerhorn <lee.schermerhorn@hp.com>
Cc: Mike Waychison <mikew@google.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Rohit Seth <rohitseth@google.com>
Cc: Edwin <edwintorok@gmail.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Ying Han <yinghan@google.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Cc: <linux-mm@kvack.org>
Cc: <linux-fsdevel@vger.kernel.org>
Subject: [PATCH 12/14] readahead: sequential mmap readahead
Date: Tue, 07 Apr 2009 19:50:51 +0800 [thread overview]
Message-ID: <20090407115235.116255177@intel.com> (raw)
In-Reply-To: 20090407115039.780820496@intel.com
[-- Attachment #1: readahead-mmap-sequential-readahead.patch --]
[-- Type: text/plain, Size: 2021 bytes --]
Auto-detect sequential mmap reads and do readahead for them.
The sequential mmap readahead will be triggered when
- sync readahead: it's a major fault and (prev_offset == offset-1);
- async readahead: minor fault on PG_readahead page with valid readahead state.
The benefits of doing readahead instead of read-around:
- less I/O wait thanks to async readahead
- double real I/O size and no more cache hits
The single stream case is improved a little.
For 100,000 sequential mmap reads:
user system cpu total
(1-1) plain -mm, 128KB readaround: 3.224 2.554 48.40% 11.838
(1-2) plain -mm, 256KB readaround: 3.170 2.392 46.20% 11.976
(2) patched -mm, 128KB readahead: 3.117 2.448 47.33% 11.607
The patched (2) has smallest total time, since it has no cache hit overheads
and less I/O block time(thanks to async readahead). Here the I/O size
makes no much difference, since there's only one single stream.
Note that (1-1)'s real I/O size is 64KB and (1-2)'s real I/O size is 128KB,
since the half of the read-around pages will be readahead cache hits.
This is going to make _real_ differences for _concurrent_ IO streams.
Cc: Nick Piggin <npiggin@suse.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
---
mm/filemap.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- mm.orig/mm/filemap.c
+++ mm/mm/filemap.c
@@ -1540,7 +1540,8 @@ static void do_sync_mmap_readahead(struc
if (VM_RandomReadHint(vma))
return;
- if (VM_SequentialReadHint(vma)) {
+ if (VM_SequentialReadHint(vma) ||
+ offset - 1 == (ra->prev_pos >> PAGE_CACHE_SHIFT)) {
page_cache_sync_readahead(mapping, ra, file, offset, 1);
return;
}
--
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-04-07 11:50 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-07 11:50 [PATCH 00/14] filemap and readahead fixes Wu Fengguang
2009-04-07 11:50 ` [PATCH 01/14] mm: fix find_lock_page_retry() return value parsing Wu Fengguang
2009-04-07 11:50 ` [PATCH 02/14] mm: fix major/minor fault accounting on retried fault Wu Fengguang
2009-04-07 11:50 ` [PATCH 03/14] mm: remove FAULT_FLAG_RETRY dead code Wu Fengguang
2009-04-07 11:50 ` [PATCH 04/14] mm: reduce duplicate page fault code Wu Fengguang
2009-04-07 11:50 ` [PATCH 05/14] readahead: account mmap_miss for VM_FAULT_RETRY Wu Fengguang
2009-04-07 11:50 ` [PATCH 06/14] readahead: move max_sane_readahead() calls into force_page_cache_readahead() Wu Fengguang
2009-04-07 11:50 ` [PATCH 07/14] readahead: apply max_sane_readahead() limit in ondemand_readahead() Wu Fengguang
2009-04-07 11:50 ` [PATCH 08/14] readahead: remove one unnecessary radix tree lookup Wu Fengguang
2009-04-07 11:50 ` [PATCH 09/14] readahead: increase interleaved readahead size Wu Fengguang
2009-04-07 11:50 ` [PATCH 10/14] readahead: remove sync/async readahead call dependency Wu Fengguang
2009-04-07 11:50 ` [PATCH 11/14] readahead: clean up and simplify the code for filemap page fault readahead Wu Fengguang
2009-04-07 15:50 ` Linus Torvalds
2009-04-07 11:50 ` Wu Fengguang [this message]
2009-04-07 11:50 ` [PATCH 13/14] readahead: enforce full readahead size on async mmap readahead Wu Fengguang
2009-04-07 11:50 ` [PATCH 14/14] readahead: record mmap read-around states in file_ra_state Wu Fengguang
2009-04-10 4:36 ` [PATCH 00/14] filemap and readahead fixes Andrew Morton
2009-04-10 4:54 ` Wu Fengguang
2009-04-10 5:08 ` Andrew Morton
2009-04-10 5:53 ` Wu Fengguang
-- strict thread matches above, loose matches on Subject: below --
2009-04-07 7:17 Wu Fengguang
2009-04-07 7:17 ` [PATCH 12/14] readahead: sequential mmap readahead Wu Fengguang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090407115235.116255177@intel.com \
--to=fengguang.wu@intel.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=npiggin@suse.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).