linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andreas Dilger <adilger@Sun.COM>
To: Oleg Drokin <green@linuxhacker.ru>
Cc: Jamie Lokier <jamie@shareable.org>, linux-fsdevel@vger.kernel.org
Subject: Re: Attempt at "stat light" implementation
Date: Tue, 07 Apr 2009 11:18:27 -0700	[thread overview]
Message-ID: <20090407181827.GV3204@webber.adilger.int> (raw)
In-Reply-To: <0891A741-6527-4BDE-9F6C-FD8FAA45E2F1@linuxhacker.ru>

On Apr 07, 2009  13:41 -0400, Oleg Drokin wrote:
> On Apr 7, 2009, at 1:32 PM, Jamie Lokier wrote:
>> If an "extensible" attribute is not asked for, the kernel must not
>> fill in that field of the structure as the app may be not have
>> allocated space for it.  Or it must use a tag-length-value sort of
>> structure for the result, similar to network CMSGs.
>
> The app allocates struct stat, whatever it is, I presume. There is a  
> huge benefit to actually reuse existing struct stat, I believe.

The point is that if the application is asking for specific fields,
it will also have allocated a stat struct that will have room for
those fields (sizeof(struct stat) would of course have to match
the AT_STAT_* flags that are available to the application).  New fields
(as opposed to using the reserved fields) would always be added at
the end.  If some flags are not set then it doesn't matter whether
the user struct is large enough because the fields will not be touched.

Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.


  parent reply	other threads:[~2009-04-07 18:18 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-07  6:23 Attempt at "stat light" implementation Oleg Drokin
2009-04-07 10:23 ` Andreas Dilger
2009-04-07 14:54   ` Oleg Drokin
2009-04-07 17:52     ` Christoph Hellwig
2009-04-07 15:22   ` jim owens
2009-04-07 15:38     ` Oleg Drokin
2009-04-07 16:20       ` jim owens
2009-04-07 17:32 ` Jamie Lokier
2009-04-07 17:38   ` Jeff Garzik
2009-04-07 17:56     ` Jamie Lokier
2009-04-07 18:21       ` Andreas Dilger
2009-04-07 19:30         ` Ulrich Drepper
2009-04-12 20:55           ` Jamie Lokier
2009-04-07 17:41   ` Oleg Drokin
2009-04-07 17:54     ` Jamie Lokier
2009-04-07 18:00       ` Oleg Drokin
2009-04-07 18:18     ` Andreas Dilger [this message]
2009-04-07 18:31     ` Nicholas Miell
2009-04-07 17:49 ` Christoph Hellwig
2009-04-07 17:56   ` Oleg Drokin
2009-04-07 18:28     ` Andreas Dilger
2009-04-07 18:50       ` Jamie Lokier
2009-04-07 19:48       ` Jeff Garzik
2009-04-07 19:47   ` Jeff Garzik
2009-04-07 20:18 ` Evgeniy Polyakov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090407181827.GV3204@webber.adilger.int \
    --to=adilger@sun.com \
    --cc=green@linuxhacker.ru \
    --cc=jamie@shareable.org \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).