From: Andrew Morton <akpm@linux-foundation.org>
To: Akinobu Mita <akinobu.mita@gmail.com>
Cc: linux-kernel@vger.kernel.org, wli@holomorphy.com,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
stable@kernel.org
Subject: Re: [PATCH] hugetlbfs: return negative error code for bad mount option
Date: Wed, 15 Apr 2009 14:59:10 -0700 [thread overview]
Message-ID: <20090415145910.22910363.akpm@linux-foundation.org> (raw)
In-Reply-To: <20090413035623.GA4156@localhost.localdomain>
On Mon, 13 Apr 2009 12:56:23 +0900
Akinobu Mita <akinobu.mita@gmail.com> wrote:
> This fixes the following BUG:
>
> # mount -o size=MM -t hugetlbfs none /huge
> hugetlbfs: Bad value 'MM' for mount option 'size=MM'
> ------------[ cut here ]------------
> kernel BUG at fs/super.c:996!
I can't tell where this BUG (or WARN?) is happening unless I know
exactly which kernel version was tested.
I assume that it is BUG_ON(!mnt->mnt_sb); in vfs_kern_mount()?
> Also, remove unused #include <linux/quotaops.h>
>
> Cc: William Irwin <wli@holomorphy.com>
> Cc: stable@kernel.org
> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
> ---
>
> diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c
> index 23a3c76..153d968 100644
> --- a/fs/hugetlbfs/inode.c
> +++ b/fs/hugetlbfs/inode.c
> @@ -26,7 +26,6 @@
> #include <linux/pagevec.h>
> #include <linux/parser.h>
> #include <linux/mman.h>
> -#include <linux/quotaops.h>
> #include <linux/slab.h>
> #include <linux/dnotify.h>
> #include <linux/statfs.h>
> @@ -842,7 +841,7 @@ hugetlbfs_parse_options(char *options, struct hugetlbfs_config *pconfig)
> bad_val:
> printk(KERN_ERR "hugetlbfs: Bad value '%s' for mount option '%s'\n",
> args[0].from, p);
> - return 1;
> + return -EINVAL;
> }
>
> static int
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-04-15 21:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-13 3:56 [PATCH] hugetlbfs: return negative error code for bad mount option Akinobu Mita
2009-04-15 21:59 ` Andrew Morton [this message]
2009-04-16 5:01 ` Akinobu Mita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090415145910.22910363.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=akinobu.mita@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=stable@kernel.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).