From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Piggin Subject: Re: [RFC][PATCH v3 1/6] mm: Don't unmap gup()ed page Date: Wed, 15 Apr 2009 19:22:03 +1000 Message-ID: <200904151922.04508.nickpiggin@yahoo.com.au> References: <20090414143252.GE28265@random.random> <20090415165431.AC4C.A69D9226@jp.fujitsu.com> <200904151822.33478.nickpiggin@yahoo.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Cc: Andrea Arcangeli , LKML , Linus Torvalds , Andrew Morton , Jeff Moyer , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Hugh Dickins To: KOSAKI Motohiro Return-path: In-Reply-To: <200904151822.33478.nickpiggin@yahoo.com.au> Content-Disposition: inline Sender: owner-linux-mm@kvack.org List-Id: linux-fsdevel.vger.kernel.org On Wednesday 15 April 2009 18:22:32 Nick Piggin wrote: > On Wednesday 15 April 2009 18:05:54 KOSAKI Motohiro wrote: > > Hi > > > > > On Wednesday 15 April 2009 00:32:52 Andrea Arcangeli wrote: > > > > On Wed, Apr 15, 2009 at 12:26:34AM +1000, Nick Piggin wrote: > > > > > Andrea: I didn't veto that set_bit change of yours as such. I just > > > > > > > > I know you didn't ;) > > > > > > > > > noted there could be more atomic operations. Actually I would > > > > > welcome more comparison between our two approaches, but they seem > > > > > > > > Agree about the welcome of comparison, it'd be nice to measure it the > > > > enterprise workloads that showed the gup_fast gain in the first place. > > > > > > I think we should be able to ask IBM to run some tests, provided > > > they still have machines available to do so. Although I don't want > > > to waste their time so we need to have something that has got past > > > initial code review and has a chance of being merged. > > > > > > If we get that far, then I can ask them to run tests definitely. > > > > Oh, it seem very charming idea. > > Nick, I hope to help your patch's rollup. It makes good comparision, I think. > > Is there my doable thing? > > Well, I guess review and testing. There are few possibilities for > reducing the cases where we have to de-cow (or increasing the > cases where we can WP-on-fork), which I'd like to experiment with, > but I don't know how much it will help... Oh, I forgot, it needs to be updated for hugepages as well, I'd say. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org