linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] autofs4 - fix incorect return in autofs4_mount_busy()
@ 2009-04-23  7:34 Ian Kent
  2009-04-23  7:45 ` Andrew Morton
  0 siblings, 1 reply; 3+ messages in thread
From: Ian Kent @ 2009-04-23  7:34 UTC (permalink / raw)
  To: Andrew Morton; +Cc: autofs mailing list, rhkernel-list, linux-fsdevel

This patch addresses bug 496766.

Fix an obvious incorect return status in autofs4_mount_busy().
---

 fs/autofs4/expire.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/fs/autofs4/expire.c b/fs/autofs4/expire.c
index 75f7dda..3077d8f 100644
--- a/fs/autofs4/expire.c
+++ b/fs/autofs4/expire.c
@@ -70,8 +70,10 @@ static int autofs4_mount_busy(struct vfsmount *mnt, struct dentry *dentry)
 		 * Otherwise it's an offset mount and we need to check
 		 * if we can umount its mount, if there is one.
 		 */
-		if (!d_mountpoint(dentry))
+		if (!d_mountpoint(dentry)) {
+			status = 0;
 			goto done;
+		}
 	}
 
 	/* Update the expiry counter if fs is busy */


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] autofs4 - fix incorect return in autofs4_mount_busy()
  2009-04-23  7:34 [PATCH] autofs4 - fix incorect return in autofs4_mount_busy() Ian Kent
@ 2009-04-23  7:45 ` Andrew Morton
  2009-04-23 13:50   ` Ian Kent
  0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2009-04-23  7:45 UTC (permalink / raw)
  To: Ian Kent; +Cc: autofs mailing list, rhkernel-list, linux-fsdevel

On Thu, 23 Apr 2009 15:34:52 +0800 Ian Kent <raven@themaw.net> wrote:

> This patch addresses bug 496766.

In which tracking system?

Please prefer to provide the full URL.  I use the form:

Addresses http://....496766


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] autofs4 - fix incorect return in autofs4_mount_busy()
  2009-04-23  7:45 ` Andrew Morton
@ 2009-04-23 13:50   ` Ian Kent
  0 siblings, 0 replies; 3+ messages in thread
From: Ian Kent @ 2009-04-23 13:50 UTC (permalink / raw)
  To: Andrew Morton; +Cc: autofs mailing list, rhkernel-list, linux-fsdevel

Andrew Morton wrote:
> On Thu, 23 Apr 2009 15:34:52 +0800 Ian Kent <raven@themaw.net> wrote:
> 
>> This patch addresses bug 496766.
> 
> In which tracking system?
> 
> Please prefer to provide the full URL.  I use the form:
> 
> Addresses http://....496766
> 

I'm asleep today, that was never meant for the public post, it refers to
a Redhat bug that has no additional information.

And there was no Signed-off-by, sorry, ;)

Ian




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2009-04-23 13:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-23  7:34 [PATCH] autofs4 - fix incorect return in autofs4_mount_busy() Ian Kent
2009-04-23  7:45 ` Andrew Morton
2009-04-23 13:50   ` Ian Kent

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).