From: Christoph Hellwig <hch@infradead.org>
To: Jan Kara <jack@suse.cz>
Cc: Christoph Hellwig <hch@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-fsdevel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Jens Axboe <jens.axboe@oracle.com>
Subject: Re: [PATCH] vfs: Fix sys_sync() and fsync_super() reliability
Date: Thu, 23 Apr 2009 09:09:46 -0400 [thread overview]
Message-ID: <20090423130946.GA3695@infradead.org> (raw)
In-Reply-To: <20090423130724.GA20896@duck.suse.cz>
On Thu, Apr 23, 2009 at 03:07:24PM +0200, Jan Kara wrote:
> > Another thing I want to do in this area is sort out the meaning of
> > write_super. I'd really prefer to have every filesystem implement
> > ->sync_fs for actual data-integerity syncs, and only leave ->write_super
> > for the periodic writeouts, as the current implementation is extrenly
> > confusing and causes a lot of trouble for filesystems doing their own
> > periodic sb writeback.
> Yes, that would be nice but I guess it's a partly a separate issue
> (and has to touch a lot of filesystems). I'll keep write_supers() call in
> the next version of the patch so that this split isn't made harded by it.
Yeah, separate issue. We need to do this sync massaging in a couple of
small steps..
next prev parent reply other threads:[~2009-04-23 13:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-22 15:56 [PATCH 0/2] Fix sys_sync() bug and slightly cleanup the code Jan Kara
2009-04-22 15:56 ` [PATCH] vfs: Fix sys_sync() and fsync_super() reliability Jan Kara
2009-04-22 17:16 ` Trond Myklebust
2009-04-22 17:23 ` Jan Kara
2009-04-23 11:10 ` Christoph Hellwig
2009-04-23 13:07 ` Jan Kara
2009-04-23 13:09 ` Christoph Hellwig [this message]
2009-04-22 15:56 ` [PATCH] vfs: Merge sync_supers(), sync_filesystems() and sync_blockdevs() Jan Kara
2009-04-22 17:20 ` Trond Myklebust
2009-04-23 11:06 ` Christoph Hellwig
2009-04-23 12:31 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090423130946.GA3695@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=jack@suse.cz \
--cc=jens.axboe@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).