From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH] vfs: Fix sys_sync() and fsync_super() reliability Date: Thu, 23 Apr 2009 09:09:46 -0400 Message-ID: <20090423130946.GA3695@infradead.org> References: <1240415781-17834-1-git-send-email-jack@suse.cz> <1240415781-17834-2-git-send-email-jack@suse.cz> <20090423111040.GB4833@infradead.org> <20090423130724.GA20896@duck.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , LKML , linux-fsdevel@vger.kernel.org, Andrew Morton , Jens Axboe To: Jan Kara Return-path: Content-Disposition: inline In-Reply-To: <20090423130724.GA20896@duck.suse.cz> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Thu, Apr 23, 2009 at 03:07:24PM +0200, Jan Kara wrote: > > Another thing I want to do in this area is sort out the meaning of > > write_super. I'd really prefer to have every filesystem implement > > ->sync_fs for actual data-integerity syncs, and only leave ->write_super > > for the periodic writeouts, as the current implementation is extrenly > > confusing and causes a lot of trouble for filesystems doing their own > > periodic sb writeback. > Yes, that would be nice but I guess it's a partly a separate issue > (and has to touch a lot of filesystems). I'll keep write_supers() call in > the next version of the patch so that this split isn't made harded by it. Yeah, separate issue. We need to do this sync massaging in a couple of small steps..