From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 3/4] vfs: Make __fsync_super() a static function (version 2) Date: Thu, 23 Apr 2009 12:52:05 -0400 Message-ID: <20090423165205.GA4083@infradead.org> References: <1240498045-14288-1-git-send-email-jack@suse.cz> <1240498045-14288-4-git-send-email-jack@suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: LKML , Christoph Hellwig , Trond Myklebust , linux-fsdevel@vger.kernel.org, Andrew Morton To: Jan Kara Return-path: Received: from bombadil.infradead.org ([18.85.46.34]:54007 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753177AbZDWQwK (ORCPT ); Thu, 23 Apr 2009 12:52:10 -0400 Content-Disposition: inline In-Reply-To: <1240498045-14288-4-git-send-email-jack@suse.cz> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, Apr 23, 2009 at 04:47:24PM +0200, Jan Kara wrote: > -void __fsync_super(struct super_block *sb) > +static int __fsync_super(struct super_block *sb) > { > sync_inodes_sb(sb, 0); > vfs_dq_sync(sb); > @@ -284,8 +284,7 @@ void __fsync_super(struct super_block *sb) I think you're missing a return somewhere :)