From: Al Viro <viro@ZenIV.linux.org.uk>
To: Alessio Igor Bogani <abogani@texware.it>
Cc: Ingo Molnar <mingo@elte.hu>, Jonathan Corbet <corbet@lwn.net>,
Fr??d??ric Weisbecker <fweisbec@gmail.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
LKML <linux-kernel@vger.kernel.org>,
LFSDEV <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH 0/5 -tip] umount_begin BKL pushdown
Date: Thu, 23 Apr 2009 20:18:17 +0100 [thread overview]
Message-ID: <20090423191817.GW8633@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1240513925-5603-1-git-send-email-abogani@texware.it>
On Thu, Apr 23, 2009 at 09:12:00PM +0200, Alessio Igor Bogani wrote:
> Push the BKL acquisition from vfs to every specific filesystems
> with hope that it can be eliminated in a second moment.
>
> The first 4 patches add BKL lock into umount_begin() functions (for
> the filesystems that have this handler). The last one remove
> lock_kernel()/unlock_kernel() from fs/namespace.c (the only point
> that invoke umount_begin() funtcions).
I'd rather collapse all these patches together; no point doing that
per-fs (for all 4 of them). And CIFS side is bogus.
Another thing: -tip is no place for that. I can put that into VFS
tree, provided that comments above are dealt with.
next prev parent reply other threads:[~2009-04-23 19:18 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-23 19:12 [PATCH 0/5 -tip] umount_begin BKL pushdown Alessio Igor Bogani
2009-04-23 19:12 ` [PATCH 1/5 -tip] 9p: " Alessio Igor Bogani
2009-04-23 19:12 ` [PATCH 2/5 -tip] cifs: " Alessio Igor Bogani
2009-04-23 19:12 ` [PATCH 3/5 -tip] fuse: " Alessio Igor Bogani
2009-04-23 19:12 ` [PATCH 4/5 -tip] nfs: " Alessio Igor Bogani
2009-04-23 19:12 ` [PATCH 5/5 -tip] vfs: Don-t call umount_begin with BKL held Alessio Igor Bogani
2009-04-23 19:15 ` [PATCH 2/5 -tip] cifs: umount_begin BKL pushdown Al Viro
2009-04-23 19:19 ` Matthew Wilcox
2009-04-24 7:06 ` [PATCH 0/1] vfs: umount_begin BKL pushdown v2 Alessio Igor Bogani
2009-04-24 7:06 ` [PATCH 1/1] " Alessio Igor Bogani
2009-04-24 7:13 ` Al Viro
2009-04-24 7:15 ` Al Viro
2009-04-24 8:48 ` Christoph Hellwig
2009-04-24 7:18 ` Al Viro
2009-04-24 7:41 ` Alessio Igor Bogani
2009-04-24 8:06 ` Ingo Molnar
2009-04-24 8:50 ` Christoph Hellwig
2009-04-24 9:16 ` Frédéric Weisbecker
2009-04-24 17:50 ` Christoph Hellwig
2009-04-24 18:55 ` Al Viro
2009-04-24 19:02 ` Christoph Hellwig
2009-04-24 20:43 ` Al Viro
2009-04-24 22:07 ` Ingo Molnar
2009-04-24 22:49 ` Ingo Molnar
2009-04-24 13:58 ` Al Viro
2009-04-24 22:19 ` Ingo Molnar
2009-04-25 7:16 ` Al Viro
2009-04-23 19:18 ` Al Viro [this message]
2009-04-23 21:32 ` [PATCH 0/5 -tip] umount_begin BKL pushdown Ingo Molnar
2009-04-24 1:57 ` Stephen Rothwell
2009-04-24 14:31 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090423191817.GW8633@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=a.p.zijlstra@chello.nl \
--cc=abogani@texware.it \
--cc=corbet@lwn.net \
--cc=fweisbec@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).