From: Jan Kara <jack@suse.cz>
To: Christoph Hellwig <hch@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Trond Myklebust <trond.myklebust@fys.uio.no>,
linux-fsdevel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 3/4] vfs: Make __fsync_super() a static function (version 2)
Date: Thu, 23 Apr 2009 22:46:33 +0200 [thread overview]
Message-ID: <20090423204633.GB31584@duck.suse.cz> (raw)
In-Reply-To: <20090423165205.GA4083@infradead.org>
On Thu 23-04-09 12:52:05, Christoph Hellwig wrote:
> On Thu, Apr 23, 2009 at 04:47:24PM +0200, Jan Kara wrote:
> > -void __fsync_super(struct super_block *sb)
> > +static int __fsync_super(struct super_block *sb)
> > {
> > sync_inodes_sb(sb, 0);
> > vfs_dq_sync(sb);
> > @@ -284,8 +284,7 @@ void __fsync_super(struct super_block *sb)
>
> I think you're missing a return somewhere :)
Argh, forgot to commit this compile fix ;).
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2009-04-23 20:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-23 14:47 [PATCH 0/4] Fix sys_sync() bug and cleanup code (version 2) Jan Kara
2009-04-23 14:47 ` [PATCH 1/4] vfs: Fix sys_sync() and fsync_super() reliability " Jan Kara
2009-04-23 14:47 ` [PATCH 2/4] vfs: Call ->sync_fs() even if s_dirt is 0 " Jan Kara
2009-04-23 14:47 ` [PATCH 3/4] vfs: Make __fsync_super() a static function " Jan Kara
2009-04-23 16:42 ` Trond Myklebust
2009-04-23 16:52 ` Christoph Hellwig
2009-04-23 20:46 ` Jan Kara [this message]
2009-04-23 14:47 ` [PATCH 4/4] vfs: Make sys_sync() use fsync_super() " Jan Kara
2009-04-23 16:57 ` Christoph Hellwig
2009-04-23 21:29 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090423204633.GB31584@duck.suse.cz \
--to=jack@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).