linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Christoph Hellwig <hch@infradead.org>
Cc: Fr?d?ric Weisbecker <fweisbec@gmail.com>,
	Ingo Molnar <mingo@elte.hu>,
	Alessio Igor Bogani <abogani@texware.it>,
	Jonathan Corbet <corbet@lwn.net>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	LKML <linux-kernel@vger.kernel.org>,
	LFSDEV <linux-fsdevel@vger.kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Matthew Wilcox <matthew@wil.cx>
Subject: Re: [PATCH 1/1] vfs: umount_begin BKL pushdown v2
Date: Fri, 24 Apr 2009 19:55:24 +0100	[thread overview]
Message-ID: <20090424185524.GO8633@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20090424175025.GA30091@infradead.org>

On Fri, Apr 24, 2009 at 01:50:25PM -0400, Christoph Hellwig wrote:

> Having a working tree for debugging stuff is fine, but the point is
> that it should never be pulled into mainline and probably frequently
> reabsed to avoid cruft.  In that case there's really no point in
> creating branches to share pieces of tree history, just apply the patch
> locally if you think you want it and merge or rebase once mainline gets
> the patch.
> 
> Al frequently rebases the vfs tree, btw - so even if it was a separate
> branch now there's a fair chance it would end up in mainline with a
> different commit id.

Nah, it's not that.  I can hold that in a separate branch and keep it
anchored.  The question is, what else will end up there?
	* the work inside the methods on BKL _removal_
	* things like merging that ->write_super() call into ->put_super(),
etc.
	* probably parts of work on s_flags mess and ro (tied to remout)

I agree that getting rid of BKL in that area is a good thing; no arguments
about that.  If it had been entirely self-contained, I'd gladly drop that
stuff into a separate branch, let mingo pull it and forgot about the entire
thing.

The things get tricky, though, since we have two more things in the same
area: remount (once Nick comes back with the latest on mnt_write_count,
I'm going to merge that and start on per-sb side, BTW) and stuff around
Jan's sync series.

So let's figure out how do we do that.  I have no problem with a single
branch for *all* of that, separate from the rest of VFS stuff.  However,
I very much suspect that it's not what mingo et.al. have in mind - too
much stuff alien for them.  I can keep a cherry-picked branch with minimal
BKL-affecting backports from that one.  It might or might not be OK,
depending on what the hell their workflow is in -tip.  I honestly have
no idea how the devil the things are done there, except that it apparently
involves much more merges than I'd be comfortable with, but then I never
had a taste for literal clusterf*cks either.

Could the folks from the other side tell
	* what kind of patches do they want in that branch
	* what kind of patches can they accept in that branch
	* when do they intend to see it merged into mainline
	* how much is going to be merged on top of that and how often
(if ever) is it going to be thrown out and re-pulled.  I.e. is that for
a devel/debugging tree pulled together from many topic branches on
regular basis, with branches dropped/re-added/etc. (i.e. something a-la
linux-next) or is that something more cast in stone?

Seriously, let's sort that out; flamefests being what they are, there's
a real problem with keeping two streams of development tolerable for
participants.  I *do* have very unkind words to say to Ingo, but that's
a matter for private mail and I'm not going to let that anywhere near
development question.

  reply	other threads:[~2009-04-24 18:55 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-23 19:12 [PATCH 0/5 -tip] umount_begin BKL pushdown Alessio Igor Bogani
2009-04-23 19:12 ` [PATCH 1/5 -tip] 9p: " Alessio Igor Bogani
2009-04-23 19:12   ` [PATCH 2/5 -tip] cifs: " Alessio Igor Bogani
2009-04-23 19:12     ` [PATCH 3/5 -tip] fuse: " Alessio Igor Bogani
2009-04-23 19:12       ` [PATCH 4/5 -tip] nfs: " Alessio Igor Bogani
2009-04-23 19:12         ` [PATCH 5/5 -tip] vfs: Don-t call umount_begin with BKL held Alessio Igor Bogani
2009-04-23 19:15     ` [PATCH 2/5 -tip] cifs: umount_begin BKL pushdown Al Viro
2009-04-23 19:19     ` Matthew Wilcox
2009-04-24  7:06       ` [PATCH 0/1] vfs: umount_begin BKL pushdown v2 Alessio Igor Bogani
2009-04-24  7:06         ` [PATCH 1/1] " Alessio Igor Bogani
2009-04-24  7:13           ` Al Viro
2009-04-24  7:15             ` Al Viro
2009-04-24  8:48               ` Christoph Hellwig
2009-04-24  7:18             ` Al Viro
2009-04-24  7:41               ` Alessio Igor Bogani
2009-04-24  8:06               ` Ingo Molnar
2009-04-24  8:50                 ` Christoph Hellwig
2009-04-24  9:16                   ` Frédéric Weisbecker
2009-04-24 17:50                     ` Christoph Hellwig
2009-04-24 18:55                       ` Al Viro [this message]
2009-04-24 19:02                         ` Christoph Hellwig
2009-04-24 20:43                           ` Al Viro
2009-04-24 22:07                       ` Ingo Molnar
2009-04-24 22:49                   ` Ingo Molnar
2009-04-24 13:58                 ` Al Viro
2009-04-24 22:19                   ` Ingo Molnar
2009-04-25  7:16                     ` Al Viro
2009-04-23 19:18 ` [PATCH 0/5 -tip] umount_begin BKL pushdown Al Viro
2009-04-23 21:32   ` Ingo Molnar
2009-04-24  1:57     ` Stephen Rothwell
2009-04-24 14:31       ` Jonathan Corbet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090424185524.GO8633@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=a.p.zijlstra@chello.nl \
    --cc=abogani@texware.it \
    --cc=corbet@lwn.net \
    --cc=fweisbec@gmail.com \
    --cc=hch@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew@wil.cx \
    --cc=mingo@elte.hu \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).