From: Christoph Hellwig <hch@infradead.org>
To: Jan Kara <jack@suse.cz>
Cc: linux-fsdevel@vger.kernel.org
Subject: [PATCH 3/5] gfs2: remove ->write_super and stop maintaining ->s_dirt
Date: Mon, 27 Apr 2009 09:46:43 -0400 [thread overview]
Message-ID: <20090427134815.794333000@bombadil.infradead.org> (raw)
In-Reply-To: 20090427134640.128837000@bombadil.infradead.org
[-- Attachment #1: gfs2-remove-write_super --]
[-- Type: text/plain, Size: 1704 bytes --]
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: linux-2.6/fs/gfs2/log.c
===================================================================
--- linux-2.6.orig/fs/gfs2/log.c 2009-04-26 20:16:25.197978791 +0200
+++ linux-2.6/fs/gfs2/log.c 2009-04-26 20:16:33.128077096 +0200
@@ -764,7 +764,6 @@ void __gfs2_log_flush(struct gfs2_sbd *s
}
gfs2_log_unlock(sdp);
- sdp->sd_vfs->s_dirt = 0;
up_write(&sdp->sd_log_flush_lock);
kfree(ai);
@@ -823,7 +822,6 @@ void gfs2_log_commit(struct gfs2_sbd *sd
log_refund(sdp, tr);
buf_lo_incore_commit(sdp, tr);
- sdp->sd_vfs->s_dirt = 1;
up_read(&sdp->sd_log_flush_lock);
gfs2_log_lock(sdp);
Index: linux-2.6/fs/gfs2/ops_super.c
===================================================================
--- linux-2.6.orig/fs/gfs2/ops_super.c 2009-04-26 20:16:36.808074171 +0200
+++ linux-2.6/fs/gfs2/ops_super.c 2009-04-26 20:16:49.267951560 +0200
@@ -185,17 +185,6 @@ static void gfs2_put_super(struct super_
}
/**
- * gfs2_write_super
- * @sb: the superblock
- *
- */
-
-static void gfs2_write_super(struct super_block *sb)
-{
- sb->s_dirt = 0;
-}
-
-/**
* gfs2_sync_fs - sync the filesystem
* @sb: the superblock
*
@@ -204,7 +193,6 @@ static void gfs2_write_super(struct supe
static int gfs2_sync_fs(struct super_block *sb, int wait)
{
- sb->s_dirt = 0;
if (wait && sb->s_fs_info)
gfs2_log_flush(sb->s_fs_info, NULL);
return 0;
@@ -710,7 +698,6 @@ const struct super_operations gfs2_super
.write_inode = gfs2_write_inode,
.delete_inode = gfs2_delete_inode,
.put_super = gfs2_put_super,
- .write_super = gfs2_write_super,
.sync_fs = gfs2_sync_fs,
.freeze_fs = gfs2_freeze,
.unfreeze_fs = gfs2_unfreeze,
next prev parent reply other threads:[~2009-04-27 13:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-27 13:46 [PATCH 0/5] remove superflous ->write_super instances Christoph Hellwig
2009-04-27 13:46 ` [PATCH 1/5] btrfs: remove ->write_super and stop maintaining ->s_dirt Christoph Hellwig
2009-04-27 13:46 ` [PATCH 2/5] ext3: " Christoph Hellwig
2009-04-27 13:46 ` Christoph Hellwig [this message]
2009-04-27 15:49 ` [PATCH 3/5] gfs2: " Steven Whitehouse
2009-04-27 13:46 ` [PATCH 4/5] ocfs2: " Christoph Hellwig
2009-04-28 16:45 ` Joel Becker
2009-04-27 13:46 ` [PATCH 5/5] qnx4: remove ->write_super Christoph Hellwig
2009-04-27 14:32 ` [PATCH 0/5] remove superflous ->write_super instances Theodore Tso
2009-04-27 14:36 ` Christoph Hellwig
2009-04-27 16:54 ` Theodore Tso
2009-04-27 14:55 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090427134815.794333000@bombadil.infradead.org \
--to=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).