From: Jan Kara <jack@suse.cz>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] quota: cleanup dquota sync functions
Date: Mon, 27 Apr 2009 16:14:11 +0200 [thread overview]
Message-ID: <20090427141411.GE7194@duck.suse.cz> (raw)
In-Reply-To: <20090426073142.GA5267@lst.de>
On Sun 26-04-09 09:31:42, Christoph Hellwig wrote:
> Btw, I think calling quota_sync_sb for the !wait case in __fsync_super
> might be a bad idea because it calls into ->sync_fs with wait = 1.
Yes, I know this. I could hack it around so that quota is not synced at
all when wait == 0 but it would be a bit surprising to future callers.
But we could just call ->quota_sync() when wait == 0. That would basically
do what's expected. I guess I'll do that.
Honza
PS: I've changed quota_sync_sb() to sync_quota_sb() and fixed one compile
error when CONFIG_QUOTA is disabled in your patch.
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
prev parent reply other threads:[~2009-04-27 14:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-26 7:31 [PATCH] quota: cleanup dquota sync functions Christoph Hellwig
2009-04-27 13:35 ` Jan Kara
2009-04-27 14:14 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090427141411.GE7194@duck.suse.cz \
--to=jack@suse.cz \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).