From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: Re: [PATCH] quota: cleanup dquota sync functions Date: Mon, 27 Apr 2009 16:14:11 +0200 Message-ID: <20090427141411.GE7194@duck.suse.cz> References: <20090426073142.GA5267@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org To: Christoph Hellwig Return-path: Received: from cantor2.suse.de ([195.135.220.15]:36709 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751527AbZD0OON (ORCPT ); Mon, 27 Apr 2009 10:14:13 -0400 Content-Disposition: inline In-Reply-To: <20090426073142.GA5267@lst.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sun 26-04-09 09:31:42, Christoph Hellwig wrote: > Btw, I think calling quota_sync_sb for the !wait case in __fsync_super > might be a bad idea because it calls into ->sync_fs with wait = 1. Yes, I know this. I could hack it around so that quota is not synced at all when wait == 0 but it would be a bit surprising to future callers. But we could just call ->quota_sync() when wait == 0. That would basically do what's expected. I guess I'll do that. Honza PS: I've changed quota_sync_sb() to sync_quota_sb() and fixed one compile error when CONFIG_QUOTA is disabled in your patch. -- Jan Kara SUSE Labs, CR