From: Christoph Hellwig <hch@infradead.org>
To: Theodore Tso <tytso@mit.edu>
Cc: Christoph Hellwig <hch@infradead.org>, Jan Kara <jack@suse.cz>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 0/5] remove superflous ->write_super instances
Date: Mon, 27 Apr 2009 10:36:00 -0400 [thread overview]
Message-ID: <20090427143600.GA18405@infradead.org> (raw)
In-Reply-To: <20090427143221.GA32264@mit.edu>
On Mon, Apr 27, 2009 at 10:32:21AM -0400, Theodore Tso wrote:
> On Mon, Apr 27, 2009 at 09:46:40AM -0400, Christoph Hellwig wrote:
> > Remove empty write_super methods and unessecary s_dirt maintainance.
>
> I noticed you didn't supply a patch for ext4, so I'm guessing you
> figured it out, but there is an (outdated) comment saying we should do
> this for ext4; however, given that we now support non-journalled
> operation, we do need to keep write_super() for when we aren't using
> the journal to write the superblock. I'll make a note to myself that
> we need to update the comment in ext4/super.c.
Exactly, ext4 needs it for non-journaled mode. It might make sense
to just give the two modes different super_operations so that the normal
journaled mode doesn't need a write_super at all.
next prev parent reply other threads:[~2009-04-27 14:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-27 13:46 [PATCH 0/5] remove superflous ->write_super instances Christoph Hellwig
2009-04-27 13:46 ` [PATCH 1/5] btrfs: remove ->write_super and stop maintaining ->s_dirt Christoph Hellwig
2009-04-27 13:46 ` [PATCH 2/5] ext3: " Christoph Hellwig
2009-04-27 13:46 ` [PATCH 3/5] gfs2: " Christoph Hellwig
2009-04-27 15:49 ` Steven Whitehouse
2009-04-27 13:46 ` [PATCH 4/5] ocfs2: " Christoph Hellwig
2009-04-28 16:45 ` Joel Becker
2009-04-27 13:46 ` [PATCH 5/5] qnx4: remove ->write_super Christoph Hellwig
2009-04-27 14:32 ` [PATCH 0/5] remove superflous ->write_super instances Theodore Tso
2009-04-27 14:36 ` Christoph Hellwig [this message]
2009-04-27 16:54 ` Theodore Tso
2009-04-27 14:55 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090427143600.GA18405@infradead.org \
--to=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).