From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joel Becker Subject: Re: [PATCH 4/5] ocfs2: remove ->write_super and stop maintaining ->s_dirt Date: Tue, 28 Apr 2009 09:45:28 -0700 Message-ID: <20090428164528.GA25290@mail.oracle.com> References: <20090427134640.128837000@bombadil.infradead.org> <20090427134815.960338000@bombadil.infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jan Kara , linux-fsdevel@vger.kernel.org To: Christoph Hellwig Return-path: Received: from rcsinet11.oracle.com ([148.87.113.123]:65151 "EHLO rgminet11.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758350AbZD1QqN (ORCPT ); Tue, 28 Apr 2009 12:46:13 -0400 Content-Disposition: inline In-Reply-To: <20090427134815.960338000@bombadil.infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, Apr 27, 2009 at 09:46:44AM -0400, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig Acked-by: Joel Becker > > Index: linux-2.6/fs/ocfs2/super.c > =================================================================== > --- linux-2.6.orig/fs/ocfs2/super.c 2009-04-26 20:17:12.088104363 +0200 > +++ linux-2.6/fs/ocfs2/super.c 2009-04-26 20:17:22.988951278 +0200 > @@ -126,7 +126,6 @@ static int ocfs2_get_sector(struct super > struct buffer_head **bh, > int block, > int sect_size); > -static void ocfs2_write_super(struct super_block *sb); > static struct inode *ocfs2_alloc_inode(struct super_block *sb); > static void ocfs2_destroy_inode(struct inode *inode); > static int ocfs2_susp_quotas(struct ocfs2_super *osb, int unsuspend); > @@ -141,7 +140,6 @@ static const struct super_operations ocf > .clear_inode = ocfs2_clear_inode, > .delete_inode = ocfs2_delete_inode, > .sync_fs = ocfs2_sync_fs, > - .write_super = ocfs2_write_super, > .put_super = ocfs2_put_super, > .remount_fs = ocfs2_remount, > .show_options = ocfs2_show_options, > @@ -365,24 +363,12 @@ static struct file_operations ocfs2_osb_ > .llseek = generic_file_llseek, > }; > > -/* > - * write_super and sync_fs ripped right out of ext3. > - */ > -static void ocfs2_write_super(struct super_block *sb) > -{ > - if (mutex_trylock(&sb->s_lock) != 0) > - BUG(); > - sb->s_dirt = 0; > -} > - > static int ocfs2_sync_fs(struct super_block *sb, int wait) > { > int status; > tid_t target; > struct ocfs2_super *osb = OCFS2_SB(sb); > > - sb->s_dirt = 0; > - > if (ocfs2_is_hard_readonly(osb)) > return -EROFS; > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- "The cynics are right nine times out of ten." - H. L. Mencken Joel Becker Principal Software Developer Oracle E-mail: joel.becker@oracle.com Phone: (650) 506-8127