From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Wilcox Subject: Re: [PATCH 3/3] fs: Add the reflink(2) system call. Date: Sun, 3 May 2009 00:27:57 -0600 Message-ID: <20090503062756.GO8822@parisc-linux.org> References: <1241331303-23753-1-git-send-email-joel.becker@oracle.com> <1241331303-23753-4-git-send-email-joel.becker@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, jmorris@namei.org, ocfs2-devel@oss.oracle.com, viro@zeniv.linux.org.uk To: Joel Becker Return-path: Received: from palinux.external.hp.com ([192.25.206.14]:58508 "EHLO mail.parisc-linux.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751290AbZECG15 (ORCPT ); Sun, 3 May 2009 02:27:57 -0400 Content-Disposition: inline In-Reply-To: <1241331303-23753-4-git-send-email-joel.becker@oracle.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sat, May 02, 2009 at 11:15:03PM -0700, Joel Becker wrote: > This implements reflinkat(2) and reflink(2). See > Documentation/reflink.txt for a description of the reflink(2) system > call. Do we need to add sys_reflink()? Since sys_reflinkat() has a superset of the functionality, presumably glibc can provide both reflink() and reflinkat() calls, and userspace need never know that glibc is calling sys_reflinkat() for both. -- Matthew Wilcox Intel Open Source Technology Centre "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step."