From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH 2/3] fs: Add vfs_reflink() and the ->reflink() inode
	operation.
Date: Sun, 3 May 2009 04:03:25 -0400
Message-ID: <20090503080324.GB27287@infradead.org>
References: <1241331303-23753-1-git-send-email-joel.becker@oracle.com> <1241331303-23753-3-git-send-email-joel.becker@oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: linux-fsdevel@vger.kernel.org, jmorris@namei.org,
	ocfs2-devel@oss.oracle.com, viro@zeniv.linux.org.uk
To: Joel Becker <joel.becker@oracle.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from bombadil.infradead.org ([18.85.46.34]:42202 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752705AbZECIDY (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Sun, 3 May 2009 04:03:24 -0400
Content-Disposition: inline
In-Reply-To: <1241331303-23753-3-git-send-email-joel.becker@oracle.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

> +int vfs_reflink(struct dentry *old_dentry, struct inode *dir, struct dentry *new_dentry)
>
>+{

Would be nice to have a little kerneldoc comment for it.  Also please
avoid the > 80 har lines

> +EXPORT_SYMBOL(vfs_reflink);

No really good reason to export this.  Most vfs_ helpers are exported
for nfsd, and I can't really see nfsd use this anytime soon.