From: Al Viro <viro@ZenIV.linux.org.uk>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: [PTCH] push down lock_super and BKL into ->put_super
Date: Wed, 6 May 2009 07:46:22 +0100 [thread overview]
Message-ID: <20090506064622.GQ8633@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20090506062300.GA12718@lst.de>
On Wed, May 06, 2009 at 08:23:00AM +0200, Christoph Hellwig wrote:
> On Wed, May 06, 2009 at 03:09:16AM +0100, Al Viro wrote:
> > As for this patch: we need to
> > * replace lock_super/unlock_super() with get_fs_excl()/put_fs_excl()
> > in the same places.
>
> Nope. See the discussion I had with Jens and other about what it
> is good for. It's for fs-central ressouces that are performance
> critical for FS. FS beeing shut down is per defintion not performance
> critical.
FS blocking writeback may very well be, though.
In any case, the point is that we should separate get_fs_excl() from
exclusion there and kill exclusion part for everything except ext4.
_Then_ we can deal with fs_excl separately.
next prev parent reply other threads:[~2009-05-06 6:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-05 13:40 [PTCH] push down lock_super and BKL into ->put_super Christoph Hellwig
2009-05-06 2:09 ` Al Viro
2009-05-06 6:23 ` Christoph Hellwig
2009-05-06 6:46 ` Al Viro [this message]
2009-05-06 7:34 ` Theodore Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090506064622.GQ8633@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).