From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias =?iso-8859-1?Q?K=F6nig?= Subject: Re: [PATCH] fix blkid.h include Date: Wed, 6 May 2009 14:13:05 +0200 Message-ID: <20090506121305.GA7278@zebra.localsite> References: <20090505214214.GC4460@nb.net.home> <20090506113550.GQ15802@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Karel Zak , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, util-linux-ng@vger.kernel.org To: Robert Schwebel Return-path: Received: from moutng.kundenserver.de ([212.227.126.186]:65133 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753855AbZEFMNl (ORCPT ); Wed, 6 May 2009 08:13:41 -0400 Content-Disposition: inline In-Reply-To: <20090506113550.GQ15802@pengutronix.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Robert Schwebel wrote: > When building util-linux-ng-2.15, I get this: > > make[3]: Entering directory `/ptx/work/octopus/WORK_2_B/rsc/svn/oselas/bsp/OSELAS.BSP-Pengutronix-AllYes-trunk/platform-phyCORE-PXA270.PCM990/build-target/util-linux-ng-2.15/mount' > arm-iwmmx-linux-gnueabi-gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I.. -include ../config.h -I../include -DLOCALEDIR=\"/usr/share/locale\" -isystem /home/rsc/svn/oselas/bsp/OSELAS.BSP-Pengutronix-AllYes-trunk/platform-phyCORE-PXA270.PCM990/sysroot-target/include -isystem /home/rsc/svn/oselas/bsp/OSELAS.BSP-Pengutronix-AllYes-trunk/platform-phyCORE-PXA270.PCM990/sysroot-target/usr/include -fsigned-char -I/home/rsc/svn/oselas/bsp/OSELAS.BSP-Pengutronix-AllYes-trunk/platform-phyCORE-PXA270.PCM990/sysroot-target/usr/include -g -O2 -MT mount-fsprobe.o -MD -MP -MF .deps/mount-fsprobe.Tpo -c -o mount-fsprobe.o `test -f '../lib/fsprobe.c' || echo './'`../lib/fsprobe.c > ../lib/fsprobe.c:10:19: error: blkid.h: No such file or directory > > The reason is that blkid.h comes from e2fsutils, which install the header file > into /usr/include/blkid/blkid.h; /usr/include is also what the .pc file > specifies for the include path for the CFLAGS. So IMHO the patch below must be > applied to make it work. > > If this is not acceptable, a little bit more configure magic would be necessary. This breaks then the build with the internal blkid library which can be selected by --with-fsprobe=builtin So, I guess some other method is needed, we might just want to set the correct include path? Regards, Matthias > > Signed-off-by: Robert Schwebel > > --- > lib/fsprobe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: util-linux-ng-2.15/lib/fsprobe.c > =================================================================== > --- util-linux-ng-2.15.orig/lib/fsprobe.c > +++ util-linux-ng-2.15/lib/fsprobe.c > @@ -7,7 +7,7 @@ > #include > #include > > -#include > +#include > > #include "blkdev.h" > #include "canonicalize.h" > > -- > Pengutronix e.K. | | > Industrial Linux Solutions | http://www.pengutronix.de/ | > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | > -- > To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html