From: "Serge E. Hallyn" <serue@us.ibm.com>
To: Daniel J Walsh <dwalsh@redhat.com>
Cc: Stephen Smalley <sds@tycho.nsa.gov>,
Casey Schaufler <casey@schaufler-ca.com>,
Eric Paris <eparis@redhat.com>,
selinux@tycho.nsa.gov, linux-fsdevel@vger.kernel.org,
linux-security-module@vger.kernel.org, viro@ZenIV.linux.org.uk,
Jamie Lokier <jamie@shareable.org>
Subject: Re: SELinux and access(2), we want to know.
Date: Fri, 8 May 2009 09:17:55 -0500 [thread overview]
Message-ID: <20090508141755.GB19721@us.ibm.com> (raw)
In-Reply-To: <4A0429A7.7060507@redhat.com>
Quoting Daniel J Walsh (dwalsh@redhat.com):
> Totally useless and gives the SELinux SUCKS crowd more ammunition. If
> the MLS people want to treat ACCESS==OPEN then we are going to have a
> big boolean/tunable flag for their paranoia. For everyone else. Lets
> try to figure out when an application is actually doing something evil.
I'm really not here to be difficult, but if you believe that a failed
open is a problem bc an attacker can poke around the fs, and you believe
that nautilus can be hacked, then ignoring access just doesn't make
sense. The fact that users are being inconvenienced doesn't change
that.
Jamie's point (obscured in code because it is implemented through
the use of fsuid) that for DAC purposes access and open use different
creds, is useful. I can buy that audit should spit out a slightly
different message to show that MAC failed on real cred attempt
instead of subj... (Even though the values of uid, euid, and fsuid
in the audit msg should make that clear).
So in that case, given how the code is structured currently in
fs/{open,namei}.c and through inode_permission, an extra flag
which selinux simply uses to judge which audit msg (if any) to
spit out seems the simplest way to do it.
-serge
next prev parent reply other threads:[~2009-05-08 14:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-07 19:18 SELinux and access(2), we want to know Eric Paris
2009-05-07 19:57 ` Serge E. Hallyn
2009-05-07 20:57 ` Eric Paris
2009-05-07 21:28 ` Serge E. Hallyn
2009-05-08 3:51 ` Casey Schaufler
2009-05-08 5:16 ` Eamon Walsh
2009-05-08 12:27 ` Stephen Smalley
2009-05-08 12:46 ` Daniel J Walsh
2009-05-08 14:17 ` Serge E. Hallyn [this message]
2009-05-08 14:53 ` Casey Schaufler
2009-05-08 13:05 ` Stephen Smalley
2009-05-08 13:14 ` Jamie Lokier
2009-05-08 13:29 ` Stephen Smalley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090508141755.GB19721@us.ibm.com \
--to=serue@us.ibm.com \
--cc=casey@schaufler-ca.com \
--cc=dwalsh@redhat.com \
--cc=eparis@redhat.com \
--cc=jamie@shareable.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=sds@tycho.nsa.gov \
--cc=selinux@tycho.nsa.gov \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).