From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 05/13] cifs: add new cifs_fattr struct for holding cifs inode attributes in common way Date: Mon, 11 May 2009 17:01:02 -0400 Message-ID: <20090511210102.GD5751@infradead.org> References: <1242073472-7100-1-git-send-email-jlayton@redhat.com> <1242073472-7100-6-git-send-email-jlayton@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-cifs-client@lists.samba.org, linux-fsdevel@vger.kernel.org To: Jeff Layton Return-path: Received: from bombadil.infradead.org ([18.85.46.34]:55353 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754845AbZEKVBB (ORCPT ); Mon, 11 May 2009 17:01:01 -0400 Content-Disposition: inline In-Reply-To: <1242073472-7100-6-git-send-email-jlayton@redhat.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, May 11, 2009 at 04:24:24PM -0400, Jeff Layton wrote: > In order to unify some codepaths, introduce a common cifs_fattr struct > for storing inode attributes. The different codepaths (unix, legacy, > normal, etc...) can fill out this struct with inode info. It can then > be passed as an arg to a common set of routines to get and update inodes. Looks good, but should probably be merged into the next patch so that we introduce a user together with the new structure.