From: Christoph Hellwig <hch@lst.de>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: Christoph Hellwig <hch@lst.de>,
viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/2] ->write_super lock_super pushdown
Date: Tue, 12 May 2009 15:25:04 +0200 [thread overview]
Message-ID: <20090512132504.GA19872@lst.de> (raw)
In-Reply-To: <4A094B02.20606@panasas.com>
On Tue, May 12, 2009 at 01:10:10PM +0300, Boaz Harrosh wrote:
> Please I have a question about this?
>
> lock_super():
> I do not see any other lock_super() in exofs, so all this might "lock" is
> race against itself, right?
Yes.
> Should I make sure that concurrent
> exofs_write_super are protected some other way and remove this?
Yes.
>
> lock_kernel();
> What is that used for? What should I check so this can be removed?
lock kernel is the big kernel lock as in the very first lock that was
added when Linux grew SMP support. If you filesystem does internal
locking you most likely don't need this one at all. The only superblock
method still called with the BKL in the vfs tree is remount, but it
will most likely be gone before 2.6.31, too. After that you can do
a quick audit if there was anything it protected against and remove it.
next prev parent reply other threads:[~2009-05-12 13:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-11 21:35 [PATCH 2/2] ->write_super lock_super pushdown Christoph Hellwig
2009-05-12 4:12 ` Al Viro
2009-05-12 10:10 ` Boaz Harrosh
2009-05-12 13:25 ` Christoph Hellwig [this message]
2009-05-12 13:40 ` Al Viro
-- strict thread matches above, loose matches on Subject: below --
2009-05-06 20:16 Christoph Hellwig
2009-05-06 20:36 ` Christoph Hellwig
2009-05-06 22:38 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090512132504.GA19872@lst.de \
--to=hch@lst.de \
--cc=bharrosh@panasas.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).