From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andi Kleen Subject: Re: [PATCH 2/2] Perform check in iov_iter_fault_in_readable() by check_readable_bytes() Date: Fri, 15 May 2009 16:01:37 +0200 Message-ID: <20090515140137.GF16682@one.firstfloor.org> References: <1242317939-15392-1-git-send-email-v.mayatskih@gmail.com> <1242317939-15392-3-git-send-email-v.mayatskih@gmail.com> <87k54iq2gv.fsf@basil.nowhere.org> <871vqqkdf0.wl%vmayatsk@redhat.com> <20090515093838.GB16682@one.firstfloor.org> <20090515134315.GB8235@shareable.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Andi Kleen , Vitaly Mayatskikh , Josef Bacik , sandeen@redhat.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: Jamie Lokier Return-path: Received: from one.firstfloor.org ([213.235.205.2]:34716 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751159AbZEON4F (ORCPT ); Fri, 15 May 2009 09:56:05 -0400 Content-Disposition: inline In-Reply-To: <20090515134315.GB8235@shareable.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: > It would be quite nice if it were safe to call read(), get EFAULT Even with that patch it is not safe, not even for write, because it's racy. -Andi -- ak@linux.intel.com -- Speaking for myself only.