From: Theodore Tso <tytso@mit.edu>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Jan Kara <jack@suse.cz>,
bugzilla-daemon@bugzilla.kernel.org, linux-ext4@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [Bug 13232] ext3/4 with synchronous writes gets wedged by Postfix
Date: Mon, 18 May 2009 09:15:48 -0400 [thread overview]
Message-ID: <20090518131548.GI32019@mit.edu> (raw)
In-Reply-To: <20090513181340.GA8128@ZenIV.linux.org.uk>
On Wed, May 13, 2009 at 07:13:40PM +0100, Al Viro wrote:
>
> OK, that's probably the easiest way to do that, as much as I don't like it...
> Since iget() et.al. will not accept I_FREEING (will wait to go away
> and restart), and since we'd better have serialization between new/free
> on fs data structures anyway, we can afford simply skipping I_FREEING
> et.al. in insert_inode_locked().
>
> We do that from new_inode, so it won't race with free_inode in any interesting
> ways and it won't race with iget (of any origin; nfsd or in case of fs
> corruption a lookup) since both still will wait for I_LOCK.
>
> Tentative patch follow; folks, I would very much like review on that one,
> since I'm far too low on caffeine and the area is nasty.
Sorry for not having time to review this until now. This looks good
to me.
Reviewed-by: "Theodore Ts'o" <tytso@mit.edu>
So Bug #13232 is currently marked as a 2.6.28 regression; do we feel
confident enough to push this to Linus for 2.6.30?
- Ted
next prev parent reply other threads:[~2009-05-18 13:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-13232-13602@http.bugzilla.kernel.org/>
[not found] ` <200905121656.n4CGu5Fl003852@demeter.kernel.org>
[not found] ` <20090513134802.GA7212@atrey.karlin.mff.cuni.cz>
[not found] ` <20090513165254.GR8633@ZenIV.linux.org.uk>
2009-05-13 18:13 ` [Bug 13232] ext3/4 with synchronous writes gets wedged by Postfix Al Viro
2009-05-18 13:15 ` Theodore Tso [this message]
2009-05-18 14:10 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090518131548.GI32019@mit.edu \
--to=tytso@mit.edu \
--cc=bugzilla-daemon@bugzilla.kernel.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).