From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [PATCH 2/2] Perform check in iov_iter_fault_in_readable() by check_readable_bytes() Date: Tue, 19 May 2009 10:55:38 +0200 Message-ID: <20090519085538.GC1366@ucw.cz> References: <1242317939-15392-1-git-send-email-v.mayatskih@gmail.com> <1242317939-15392-3-git-send-email-v.mayatskih@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Josef Bacik , sandeen@redhat.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: Vitaly Mayatskikh Return-path: Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:40392 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751179AbZESI4z (ORCPT ); Tue, 19 May 2009 04:56:55 -0400 Content-Disposition: inline In-Reply-To: <1242317939-15392-3-git-send-email-v.mayatskih@gmail.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Hi! > This patch changes iov_iter_fault_in_readable() to use check_readable_bytes() > instead of fault_in_pages_readable(). It allows iov_iter_fault_in_readable() > callers to know how much data is accessible and proceed with it. It makes > sys_write() more POSIX-friendly. I agree with andi here: yes, your suggested behaviour is 'nicer', but I don't the code complexity is worth it. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html