From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 02/13] cifs: make cnvrtDosUnixTm take a little-endian args and an offset Date: Tue, 19 May 2009 10:06:25 -0400 Message-ID: <20090519140625.GC27274@infradead.org> References: <1242245094-7319-1-git-send-email-jlayton@redhat.com> <1242245094-7319-3-git-send-email-jlayton@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, linux-cifs-client@lists.samba.org To: Jeff Layton Return-path: Content-Disposition: inline In-Reply-To: <1242245094-7319-3-git-send-email-jlayton@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-cifs-client-bounces+glfc-linux-cifs-client=gmane.org@lists.samba.org Errors-To: linux-cifs-client-bounces+glfc-linux-cifs-client=gmane.org@lists.samba.org List-Id: linux-fsdevel.vger.kernel.org On Wed, May 13, 2009 at 04:04:43PM -0400, Jeff Layton wrote: > The callers primarily end up converting the args from le anyway. Also, > most of the callers end up needing to add an offset to the result. The > exception to these rules is cnvrtDosCifsTm, but there are no callers of > that function, so we might as well remove it. > > Signed-off-by: Jeff Layton Looks good. Reviewed-by: Christoph Hellwig