linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
To: linux-fsdevel@vger.kernel.org
Cc: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Subject: [RFC] few hacks to optimize write-back
Date: Fri, 22 May 2009 21:38:20 +0300	[thread overview]
Message-ID: <20090522183820.29556.68026.sendpatchset@localhost.localdomain> (raw)

Hi,

I've spotted that the periodic write-back threads wakes up every
5 seconds, even though there are no dirty data. And it still wakes
up and wake up and disturbs the CPU which is resting in a low
power consumption state.

I've tried to optimize this a bit and make the periodic
write-back stop when there are no dirty data.

Here are 2 patches which kind of help. They are just quick
hacks. I did not want to spend much time on this and I'd
like to get some comments/directions first:
 * I'm not sure I went the right path;
 * there are new per-BDI patches from Jens, and I probably
   should work on top of them.

AFAIU, the periodic write-back may be stopped if there are
no dirty inodes and no dirty super-blocks. And it should
start an inode or superblock is marked as dirty.

For inodes, I've hooked to '__mark_inode_dirty()'.

For superblocks. Well, probably a new VFS helper like
'mark_sb_dirty()' should be introduced. Also, FSes
currently may mark SB as clean directly, but probably
they should use a 'mark_sb_clean()' helper. FSes
should not touch sb->s_dirt directly. Anyway, I have
not implemented this part.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

             reply	other threads:[~2009-05-22 16:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-22 18:38 Artem Bityutskiy [this message]
2009-05-22 18:38 ` [RFC] [PATCH] write-back: introduce a handy helper function Artem Bityutskiy
2009-05-22 18:38 ` [RFC] [PATCH] write-back: do not wake up unnecessarily Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090522183820.29556.68026.sendpatchset@localhost.localdomain \
    --to=artem.bityutskiy@nokia.com \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).