From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: [PATCH 06/12] writeback: separate the flushing state/task from the bdi Date: Mon, 25 May 2009 12:36:24 +0200 Message-ID: <20090525103623.GU11363@kernel.dk> References: <1243236887-3931-1-git-send-email-jens.axboe@oracle.com> <1243236887-3931-7-git-send-email-jens.axboe@oracle.com> <20090525101323.GD23546@duck.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, chris.mason@oracle.com, david@fromorbit.com, hch@infradead.org, akpm@linux-foundation.org, yanmin_zhang@linux.intel.com To: Jan Kara Return-path: Received: from brick.kernel.dk ([93.163.65.50]:36345 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753602AbZEYKgW (ORCPT ); Mon, 25 May 2009 06:36:22 -0400 Content-Disposition: inline In-Reply-To: <20090525101323.GD23546@duck.suse.cz> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, May 25 2009, Jan Kara wrote: > On Mon 25-05-09 09:34:41, Jens Axboe wrote: > > Add a struct bdi_writeback for tracking and handling dirty IO. This > > is in preparation for adding > 1 flusher task per bdi. > > > > Signed-off-by: Jens Axboe > ... > > static int bdi_start_fn(void *ptr) > > { > > - struct backing_dev_info *bdi = ptr; > > + struct bdi_writeback *wb = ptr; > > + struct backing_dev_info *bdi = wb->bdi; > > struct task_struct *tsk = current; > > - > > - /* > > - * Add us to the active bdi_list > > - */ > > - mutex_lock(&bdi_lock); > > - list_add(&bdi->bdi_list, &bdi_list); > > - mutex_unlock(&bdi_lock); > I'm probably missing something but I cannot find where the bdi is added > to the bdi_list after this patch... For some reason, that part is now in the following patch. The two hunks should just be deleted, good catch! -- Jens Axboe