From: Jens Axboe <jens.axboe@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jan Kara <jack@suse.cz>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
chris.mason@oracle.com, david@fromorbit.com,
akpm@linux-foundation.org, yanmin_zhang@linux.intel.com
Subject: Re: [PATCH 04/12] writeback: switch to per-bdi threads for flushing data
Date: Tue, 26 May 2009 11:07:42 +0200 [thread overview]
Message-ID: <20090526090741.GE11363@kernel.dk> (raw)
In-Reply-To: <20090526085905.GA5094@infradead.org>
On Tue, May 26 2009, Christoph Hellwig wrote:
> On Tue, May 26, 2009 at 10:56:48AM +0200, Jens Axboe wrote:
> > > Hmm, so each BDI flusher thread is going to sync all the superblocks?
> > > Isn't there a better way? I suppose we *should* be able to somehow go
> > > from a BDI to a superblock (or maybe a list of those) so that we can write
> > > per-fs metadata not bound to inodes.
> >
> > I just moved the sync_supers() to the bdi_forker_task(). That makes it
> > global at the same interval of wakeups, instead of doing in the bdi
> > threads. It would be nice to sync locally instead, but that's something
> > that can wait for later (if ever).
>
> For now it might be easier to just have a separate thread for calling
> sync_supers instead of interwinding it with the data writeback.
>
> Btw, XFS currently has a per-device thread for that, to avoid any global
> contention.
That's basically what the mentioned change does. bdi_forker_task() is a
the default_backing_dev task, it does little more than simply setup new
threads and such.
--
Jens Axboe
next prev parent reply other threads:[~2009-05-26 9:07 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-25 7:34 [PATCH 0/12] Per-bdi writeback flusher threads #5 Jens Axboe
2009-05-25 7:34 ` [PATCH 01/12] ntfs: remove old debug check for dirty data in ntfs_put_super() Jens Axboe
2009-05-25 7:34 ` [PATCH 02/12] btrfs: properly register fs backing device Jens Axboe
2009-05-25 7:34 ` [PATCH 03/12] writeback: move dirty inodes from super_block to backing_dev_info Jens Axboe
2009-05-25 8:42 ` Jan Kara
2009-05-25 8:51 ` Jens Axboe
2009-05-25 7:34 ` [PATCH 04/12] writeback: switch to per-bdi threads for flushing data Jens Axboe
2009-05-25 9:58 ` Jan Kara
2009-05-25 10:34 ` Jens Axboe
2009-05-25 12:10 ` Jan Kara
2009-05-25 12:16 ` Jens Axboe
2009-05-25 12:34 ` Jan Kara
2009-05-26 8:56 ` Jens Axboe
2009-05-26 8:59 ` Christoph Hellwig
2009-05-26 9:07 ` Jens Axboe [this message]
2009-05-25 7:34 ` [PATCH 05/12] writeback: get rid of pdflush completely Jens Axboe
2009-05-25 7:34 ` [PATCH 06/12] writeback: separate the flushing state/task from the bdi Jens Axboe
2009-05-25 10:13 ` Jan Kara
2009-05-25 10:36 ` Jens Axboe
2009-05-25 7:34 ` [PATCH 07/12] writeback: support > 1 flusher thread per bdi Jens Axboe
2009-05-25 7:34 ` [PATCH 08/12] writeback: include default_backing_dev_info in writeback Jens Axboe
2009-05-25 7:34 ` [PATCH 09/12] writeback: allow sleepy exit of default writeback task Jens Axboe
2009-05-25 7:34 ` [PATCH 10/12] writeback: add some debug inode list counters to bdi stats Jens Axboe
2009-05-25 7:34 ` [PATCH 11/12] writeback: add name to backing_dev_info Jens Axboe
2009-05-25 7:34 ` [PATCH 12/12] writeback: check for registered bdi in flusher add and inode dirty Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2009-05-26 9:33 [PATCH 0/12] Per-bdi writeback flusher threads v7 Jens Axboe
2009-05-26 9:33 ` [PATCH 04/12] writeback: switch to per-bdi threads for flushing data Jens Axboe
2009-05-25 7:30 [PATCH 0/12] Per-bdi writeback flusher threads #5 Jens Axboe
2009-05-25 7:30 ` [PATCH 04/12] writeback: switch to per-bdi threads for flushing data Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090526090741.GE11363@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=chris.mason@oracle.com \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).