From: Damien Wyart <damien.wyart@free.fr>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
chris.mason@oracle.com, david@fromorbit.com, hch@infradead.org,
akpm@linux-foundation.org, jack@suse.cz,
yanmin_zhang@linux.intel.com, richard@rsk.demon.co.uk
Subject: Re: [PATCH 0/12] Per-bdi writeback flusher threads v7
Date: Wed, 27 May 2009 07:49:21 +0200 [thread overview]
Message-ID: <20090527054921.GA4127@localhost.localdomain> (raw)
In-Reply-To: <20090527052101.GA28517@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 1029 bytes --]
> > > OK, I spotted the problem. If we fallback to the on-stack allocation in
> > > bdi_writeback_all(), then we do the wait for the work completion with
> > > the bdi_lock mutex held. This can deadlock with bdi_forker_task(), so if
> > > we require that to be invoked to make progress (happens if a thread
> > > needs to be restarted), then we have a deadlock on that mutex.
> > > I'll cook up a fix for this, but probably not before the morning.
> > Untested fix. I think it should work, but I haven't run it here yet.
> Thanks for your feedback and explanations. Will not be able to test the
> patch before the afternoon. Will then give feedback as soon as I can. Of
> course, I can also test a new fix or series if you send one in the
> morning, after your own testing.
Just ran a quick test with your fix applied and ran into the same
problem: manual sync stays in D state. I could capture SysRq-T, I am
attaching part of the output (which was very big and continuously
displaying).
Hope this helps,
--
Damien Wyart
[-- Attachment #2: sysrq_t.gz --]
[-- Type: text/plain, Size: 5711 bytes --]
\x1f\b\b#Ô\x1cJ\0\x03sysrq_t\0í]Is+9r¾ûWð>ÑÑØ\vÕá°\x0föuNã#&&*PX$¸\rI½Å¿ÞH\0µ¤ÕCö[ºtЫ'\x12¥_~\0\x12\x7f5_W¬Zê7!\x7fcdÕ\x1e÷¯þ|ö«\x17\x7fÜùÍo«ÿ2Íê\x7fÆúßþí¯\x1f}yõ÷\x7f·óPIõ\x1fÿXýçêd½{Ýø¿/òWò
r¼\b\x1fäDDó|<¯·~ÿznf÷\x04"92½Dʤ\x13e\x0ekÛ´c³Þýñøz8GyÌDy`å)Ï-Iò\x0eûͦé^[Z \x02\x15\bôxª4ÐíÓ×S\x03rA®@\x0e¥hAØ: jÏf\rÍ!QJíðB¨R}÷>\x17_DHv[ÄÆÎ«?Ì_\x1dýÁ³w+±19akõ<°qHíKs8z¿=^[hÃë!¶¢u±\x19. åÕç_ó> j$ê\x04ÌK\x7fGðvTDýÁ°\´§ôÏù`^7¹gMxÝÙóz¿+ìÑâ¤'®¼íÒ³Æî·Û$Cÿd\x1fzÒÚ7²N_w¶yñ_A\x1aÿ\x15zÆ<w¤ÊZ¼ï1ö¶9zãL\x10!7\r;ò\x19ÁsÓ^wë/Íé\x1cEmß¹íé ^e\b¿®´Ø¾rf9O\x02üywJj^[~4ÁÐHÀ\x02eù
f:6a\x7fül\x0eE,Ì0&þøf\x11\x17LMB¼ÿrnü'¿\x030 ð*©B·J\x04\x01Ùnâ»LR"@\x1d÷OÇø\x16:¡m^[
ZôlcÁ¶ídÜÆpL
&J´"|/Ñë¬\x05v\x7fHøózòGÀuí\x1e«+á|³Þ\x1d^Ë\x1c\x03ëEqÒ&06\x0fÿäü§¤iÐa¤hÝ®þþþ\x0f40òºÎòÂi·?¯ÃׯX^[-\x01>Ä\x19ÿÔ´ºRM#¿³a^^[Ah0©\x02°Gãm¡¸ßË(íáÐ+
¥4°ÊêNyÞD3oMj\x0fe]\bm|6^[÷qn¿ûÅØÕßVAYQkAVð\x13\x7f3¢ªøDkiXP\JªÉ¤\x1f²¼:þ¥\x17l¨*¥ó\x03·^\f\x7féckâ$\x16fQ#T_%¡Q\x1c¬*ÿE\x10\x02ß¡\x0ejêK
\x10Zë5ÆXä
Z\x1d\v+\x1a<ïkz÷¡
ù§\x12\b=Ïs?y\x18Õn^`\x1eÁÄf\x0e\vÅ÷¡×µöSz=°Öd\x19j´\x19eê\fâ§\x1dÌÑg\x18'\x05.ÐÍb0waâÞ~Ê&±ä¡\x1fsQw3å\x7f=ï~»ÿä¯-
\x02æ)!fà4f½ïðÀ\x03\x1e\x04óM¨V_gèà;D1¥U6Á&©Ðªóë´È\x18>Ç·`ÎJDI¡JðÖýîOeU\x13Dn·æ\x10»ø¥P\r£ÅѶ4
2J_\x11Ä|5We¶^[÷$ëð´\x0f\x01¸\x104I´\x1eE^[Søí§ÐÛ\x18\rvÊà\x1d¿ïÆN=¹íjøù^[<ÖìTÅògÎ\x05E\rdl§d´A\x1alE'¸·Jù;Á¬"iå"º}qlMJ';EÇvjôÐËíkêKÅÿ¶6N"NÔ Ø¥v\x10>òJw\x0fö\x1dËõ\x10;F4{Ìëä¸}º úÔ\x03ÂÎÌ%&´Ä¦1!>/&ôÝû²wW(ÑÕlx!-
;°ÚÃ<\x0fNxË&v=EOÃé¥\x05S\x03\x1f\x13x"T\x19âË*Ò\x1cüPåh÷o\x18Y5ò·Ãq¿í=îLa°ÚǼR%\x0e\x10ÒüóÕ¿FU6ëMGmgÐÆè9±¡°ðM#aÓ:"Æ\rZÀ84È3#½\x1e\x1aöù¸>ûæt§ô\x11ÍB`ä\x03ïGÞù4ö0»`¼³®Eúw<
ÁÈ,â~ôÿ~ÝBe£ °Þ\x1cýÁ\x03U)~¦<dïT\b§Ávw\bÓnßø/õ\x11\x06Z{4¬eY;d»ÇR·Ðù.a^[¦ÚìO¦qh\x7fJs\bpX¢\x03²÷!ÄöõprcB\fÔÎ =\x10âZÍ#Ä\O\b±R4R=\b~7pckªõÀdOÄ5µ£ãÀM)\x05^[W£Öjz)Y~¥¯³Þñwb#ÀMùy\b!Ný,Æ\x0eÔ\fVm`R· ô\fbß[ìFrW"æÏf碤ívè[¢Ò¡õDK)E¯±>\x11à.\x0e$\0ý©³dwÏ%²û¨°9»Of \x17¶WaJ«y*ÌøX
\r·ÆKá\aÁ\x1f¨0\x14ÇÖ$nû´L³ô`¹$\x19>:\x15N¥
kywié¤.q\x12÷V
éð 5µñ×ðQ÷¨pjØdMçt6Çâ96»S¡(s\x14ñ\x0eº\x1cèl÷Îìö§÷æTèùÍ)\v]߯ÂÅz£4ΦËrýÊ;Á¯1åfµ¤GIÿ\0[$Ú\x15º >îw\x17úK)\x1dôëYú«¸\x18¯0o¤¤&\fß×ßT\x1c[ººvrU\x7f{\x13KÁ'ªj1Fa®þFOúþ¦¿,ú»èï\x03ô7ø³}ÞF÷»×_'\x7f¯¿j.
n2±¬¿Y\x19\x04\x0fÚ*MÍZ>¢¤]qlM\µ¿2Hp)s\x05þ¢TªÌ}\f
îÄ]ªm"ÛÑw.êνT?þæî\\x11]VGS¸\aë.Þ \x104ù(F\x06|únêüà´õC\fÃo¼\x05!¼ÍkhøMg5¯eqÓw®i_Ok\x7f:7OñÛÐI&I
\x1d¡\x1d{ºYMBé^[èHTÞ6vÖä 0\£·ÿÔTÕä kzh±^ìm±5¾D^¢»¶È&OS]£càÄÕ%j´3çõ'ß¶\x1cuª3Ì~îÓ«D·Q²wG\x16)© E\x10ø¾.;6¿É6;ïØ¬My)øêÒòÅ\x10\æ<UØ9{¯0õ#6&TD3ÚÅÍ~ÿ&k\rêãÐ\x16My¯hY¹8ú´Ü×£*MªH-vÎÆÑ
Áõä\r\x06ë¼\a^[w/âÃË-\x11²Ãø9?\x0f½£y9\x05ÅLJ¨º.\x11"XÉÒ\ftNU\x7fôÊ{îuQÄÞ\x12®L7TZ\rãhä»ß\x1eÖh\x05\x1e½ÿ2TZD#ú}ûv\x1dÏùüµó¼C\x1cx\x05ô´cîÍò¼¹¬Ú±çþ\x12i.G7å\x05ÕÇûâØÜmÏ;\x0ff)u¦ÑR\bBR¤x\x14¸àw\x11×5sä\b\b§¹\x7f\x7f×¢l \x18Mü=»A`ü2^÷[X|ý½ë8\x15`\x1e4öÙ¬aª§õ¯\x1f4\x10.*'IG\x19Íÿ\x14IZ8zß9\x11lqa,Oã\\x7f7ÝÚeâRXALZÅsvMT~7)üúºôÂf;\0R6n}²MdU\0(ü^[ Ø?¦ÝeÿÈÌÞißV}ï\f\x05¸Tc\x17e@oe9"`ã]ñÑF÷*þnÞ»
×j\x02×õL¸\x16·áZ!à\x1a^[(_U×\x03-#¸öFò ;¸V÷kÿ1\P-p½Àõ\x02×\v\?\0®
4f\f×ÌkeÈu¸.?k(©½ºµd®\x13¡O4Û\x16¸N¥î\x06× à-p½Àõ\x02×\v\?\x04®[?k:]Óp\x04\x7fÄ®)\x1a®+öÎÑ®Û\x12\fñtìÝ\x15®1ì,p½Àõ\x02×\v\?\x06®Å\x04®gdp¨oõ@À5vãvüjk[àºíc×õ\x1dá:þFÀ5]àzë\x05®\x17¸~L0ÄNàÏ\f¸^[±ë"ø\x04)P\x1c[Sø8v][2Ù¤_JÁ&}O1\x03ô\x1e\\x7fé»p]Ū\x1f\x04×\v´.к@ë\x0f\x05ÓÀ
\aRßVDà\x02ck2\x1fïâ¨H3«.ÎJÝ S\x04\x13nÃÂ\x17¸^àzë\aÀu-(Àµ ×òFà¢\bþ\b®±)âW\x15bY°Ût§ºÀ
T÷\f\PD¹j\x17¸^àzë\x05®ï\x0f×\x10K²ëY§^[¹\x14æ:»î\x04\x7f\0×P\x1c[Elºëã̤Àu*u7¸f\bvÜ\x02×\v\/p½Àõ#ص'ÓMw³ÁD8$·Øu\x16üA\x19ck¢ï°ë\\x13±-³ÓDÜ©T3£Îâv\b¶êpèz>§wàÚê?Gù;kÎÏ\v>ÿðø|:í8ß^¦£d!LÀ\x19\x16ZqÌQشΦ.è4\x15£\x14<\x1f\x03*ü: ¾\x1e¬\x1e\x12v´¢
\x1d\x13|N¥â\x17[oPª~3YÈÕºÓÃ
,©8¾Q*o%ú;u¯cЬæÊdÞì÷ÖØæË6u* B7yë</¦ãSól®ä)⨼ L Ó0\x1aLìf³ðÖ´ÏßAª
f\r3J¦¹ØãÌG£múöå\f!¥i,%\x04æè4æH%ròÕõ¡ ëÝúôÜÄiyx=³äí¥\fÚ%¢um'.÷µð¤ÒØ\\x04±Y\òNδ.ó\0´¡\x12¼u9mFÊ9\x13gYòiÿRòjã³t\vîJÞoÈ%Þ I\x03V\x18\x1f¸ÏsôK´¼k{jíÞÁ\x15Jvÿ
\x06\x10\x19U)\v\x18>ïÉO~\x1eóÊ.Ê\vÄ!Jþñ¤53riw-¹ ·ù
^[ô\¿·@ªâ¬Ïþeë·\aÅ×ÙÅ]$@\x0e:oÆÝÛö½fé¾k"\x15Ê$']îߨù(¨æóèõ\x12~³è}\x17ı×-ä2»¯MYCJ[ÏÿË|Éo\x1fÛôùСË"|Ë:?g"½\x12Ifz%ü"jtÝ+ R·äM
Ã\\x1c[Ó\x14Âg\x10+ð\x17\x15¤ROaXêν\R\x18.~Óâ7-~Óí7ýì\x14þOV\x11¤¹ú4pë\0"ðDYQ>\x10åé\x05;)â\x0f\x7fÃÎÂÝ\x17îþr÷íù0æî±Óº¿Á'Ú´¢PsÔÕËR6\x1f\x04íÓSV\x19á\aÁ#î.\x03QB\v!kÝ\x17ÇÖtý h_Sú¯Rõú¼/\x15$·:Hä\x06è¹PÝ\x19gRϺ\bß±TbòKu\x0fáîwA;ÔúÖJmåçÔJQ®=\x1c÷pÛúHTbXA?ýå=vãÍîõÐk¯M«k¡\x1d´²Ú;¹< ¤Ü ¢àöÆXÖ^:h/2\x05)|õz
R*k.">^h¯\x1aJÅ\a%gko.3h¯ózúðxíÍ#æÀ±mÖ»þÝoö½\x06·x_t\x01?5\x10$qdÆÐU\bÌÏ\x03\x02MÆf\x1cú-\x14WàÑÍԵѯ\x18>êckúhãÖ\x18`\x12\x1aõ¥fÔ\x026ökõâ2"ÔK]{?È]\x05ÕºU¤tN?Ƨ¡ÍóüìáÆsclïacN=F_zZà ß\x12£\x02¶
Þ@ûÄiDò¢bZ\fL¿Âzã;\rR©m5Úßû×AjCw£ML
Yzà {'\x12@'5\x14TÀr\x14¥èäé\x0f\x02\bi<\x02\x05\x10UÉ p\x01\x10à)@¤ãüÝG]qlMác®ShCå3@äR3jº\x06\x10EÜUÈ\x03\x01ÂêÒ¹\x05 \x16ø9\0âíU¾\x11 æ\x05\x02ªr°²s%àæMÐ\x18ÔU¾¥8¶¦ë\a+á\x01*`¸L\\*ÚuQá] åìË\w%\x1cÜü4yÈ¥ºf=ÄHÝËs mØÉ7K§õ¬Å
X\ßëB¸ C`ób U9ªwÍ
p\f¡¢fø¨+É~È\x10ú\b#£¢0TjFMW],î:CH\x03\x18#¤tna\b\vCø1\x19ÂéyÿùS@§\fÍt!J¦ÑRh[?\bþ! 3åÀWÍ{gyë\x12l$!ëJÅ\x0fZ©(f%¿åVúmMÝCùu¶ÍK\x05Z\x19òP°ØåÆ.+©§¡½t\x11Â\x1c»ì¯ö:ÁS»\{2|Ô\x15ÇÖ\x14С½Ö)ÛÙå Å®zîYÜ\r»ì»Ð
ºSç\x16»¼Øå\x1fÓ.oöOëÝØ.S+Ô(3×lN\x06;°{t|(0ÅÉ[)\x06Á\x15\x0eÁDÓ(Vñ¨hªêckâ×»&2¢·\x06Îl´U%Xo\b\x19J¥\x10\x1cn£o+Þv.u
2¢xZ½04T¶|g°ÝbF~Ï\x12>ÔÞïxÉSܪ4^[±óè\x1ejÇHÅÌfÐVÌjǽí'#Úò^Ë Qpi:¼;ãNè»èØÛ®Vc\x1d{Ë}µg\x18Eìª'S\x1d«R\x06u$÷Mű5]7Â\x06]»v7Ü7\x02îëÂàF/å&÷¥Ã\x03T@\x15Äêñ¾B°ìoÂ}©ª9ËÛ0\x0fëCoÒÖP
Þøõ\0K¤jÃGí*;ø¥éä þvùºªØ¨{°\a3ísôi#~+ûö\x14>b¨¨tª^[ªÈ)vþ˹»É¦K»Ñ;¢yP¬Û;QBCÀU¶èùÀI«Ûa^66\x1d{xÂ4L-6c³>\x1fïù\x1füÌÿ¹\x12&üïþø4Æí6££I\WÀ\0¾±Å^\x1eM¢êÚÑ$¡ë0=Tckr×&q¯d¤*¹\x02\x7fQy4©\x13w ×ÃѤþ;\x17uç^.G£IX?øÑ¤9WÛèÀ'¿:ú7gïVr\x05#rÂ.×qÂ\>gÒ®Ï}=Ò¦?ÁÓQe&·ËYå,Í\x04L^ß:K\x13£4â«à[µõ½¼ÎÛË{Ç\b\x1f\vUaª!(mÍÎz R\x12ð[¢1Q"Èßçu×0b\x055Úãø9Ó<¹íSÄàXºãì\rßLÏ3øfõæ8\r03RÏ ¼»F½W\r¾zó^5ËEÈÏ
JL×Ⱥ{Õ¬q\x15¦O½¸·|óÆE=oêN\x0fClGY\x12tý\x11lNY5Àç©ÛxÄtâs\x14ï1~g|ÍâsKWçðÉyhØþé\x18ÿ\x14ä/%û\x12C{)\v«û9X\x1dóÜjØ\x17{è\x05êï6#©(\v\x05c"\x15MËD¦sýLcà¿WÇ ÷\x19Fͬ÷\x1d)ó)Ó8z9â;\x0eFB\b1ÈË\x10¢bf\bñ~4ÊkÃz\x1aU\@s4\x1aïC¢þïô<YlI«¼\x1a-hÖÕ*¯k"©Í4PÚµ6^[t? QØ|BðUqc+²qDé²\x01Ñv\v=\x1dJ¥ìHâ0Ý\x13¤´¦Öæ½,§mpË\x10+ÐÂVZå\aC\x1f´ã!µ'{B>¾yÛÖORë\x1d AJ2#Ðþ¯/lJ+Ô\x10>CsN¯'h\x11x-à$Xô®¥;m¤P4Ìïÿ\x1eÞT7¿k\x1a/\vH¸\x18/Øg\x0eßêñ4ésöZ\x164²\x12Úµ-ç¼/I]ÝHårØ;DEm5ï>òC©î˨\x14o\x03ä\x02ât+êiíóGJÚqø;òÞðÅÄܽÌÊ}\x11ýþ%ò³If8Íp4\x17J½KÒr¬&gB\x04É)\x1aï ¨ÑT/HÇ_@`I Aæ4ê\x1ejWi'2+hÝ:[¸nÑTÎ w±)Q=![ý®iÄÅ$%Bêë\rÃ6clqðÀ£Ûf³Þù7Mk¡-ÚjÞ©i@SD@hù\r?áèä06ömJS)¥Ë*PW¥u\x17¦bnK6ø'¿óǵÍ|ì\x04±²½KsÁ \x19fK*¯$)\x02»ÈO
v¯£$߯æ\x0e²`_Sá;Ù²Öù&ô
à@ \rL\x14\x11\x06kUdÄVÿX^[\x15ßú/ú72]8Ú¨rã4rÃK¥LÞi?¦ 5çöºÁÁ\fµW\x03Yɽã>tA4:\rd¥RÀÁjzåI\b×i 4¾µÊ~\x14Èj#\x0f¥ºØ¨ÔÏì\x1d\x01³òz J ÎJ÷Ón\x1a¯jBä\x15t+ÛA\fhýɦ$\x13j0 i:\x18ÐQö(ÉkrÈ,1Ì:1ååü\è\x14&Px\x1fÚ:¦Þ ³$\x10ÎHÔùïMÓ<ûÍ!-AT\x19'ÿ\x1fWºÂ²þÍ\0\0
next prev parent reply other threads:[~2009-05-27 5:49 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-26 9:33 [PATCH 0/12] Per-bdi writeback flusher threads v7 Jens Axboe
2009-05-26 9:33 ` [PATCH 01/12] ntfs: remove old debug check for dirty data in ntfs_put_super() Jens Axboe
2009-05-26 9:33 ` [PATCH 02/12] btrfs: properly register fs backing device Jens Axboe
2009-05-26 9:33 ` [PATCH 03/12] writeback: move dirty inodes from super_block to backing_dev_info Jens Axboe
2009-05-26 9:33 ` [PATCH 04/12] writeback: switch to per-bdi threads for flushing data Jens Axboe
2009-05-26 9:33 ` [PATCH 05/12] writeback: get rid of pdflush completely Jens Axboe
2009-05-26 9:33 ` [PATCH 06/12] writeback: separate the flushing state/task from the bdi Jens Axboe
2009-05-26 9:33 ` [PATCH 07/12] writeback: support > 1 flusher thread per bdi Jens Axboe
2009-06-04 17:44 ` Paul E. McKenney
2009-06-04 19:48 ` Jens Axboe
2009-05-26 9:33 ` [PATCH 08/12] writeback: include default_backing_dev_info in writeback Jens Axboe
2009-05-26 9:33 ` [PATCH 09/12] writeback: allow sleepy exit of default writeback task Jens Axboe
2009-05-26 9:33 ` [PATCH 10/12] writeback: add some debug inode list counters to bdi stats Jens Axboe
2009-05-26 9:33 ` [PATCH 11/12] writeback: add name to backing_dev_info Jens Axboe
2009-05-26 9:33 ` [PATCH 12/12] writeback: check for registered bdi in flusher add and inode dirty Jens Axboe
2009-05-26 15:25 ` [PATCH 0/12] Per-bdi writeback flusher threads v7 Damien Wyart
2009-05-26 16:41 ` Jens Axboe
2009-05-26 17:08 ` Damien Wyart
2009-05-26 17:10 ` Damien Wyart
2009-05-26 20:47 ` Jens Axboe
2009-05-26 21:11 ` Jens Axboe
2009-05-27 5:21 ` Damien Wyart
2009-05-27 5:49 ` Damien Wyart [this message]
2009-05-27 9:20 ` Jens Axboe
2009-05-27 13:15 ` Damien Wyart
2009-05-27 15:05 ` Jens Axboe
2009-05-27 21:06 ` Andrew Morton
2009-05-28 10:20 ` Jens Axboe
2009-05-27 6:17 ` Jens Axboe
2009-05-27 5:27 ` Zhang, Yanmin
2009-05-27 6:17 ` Jens Axboe
2009-06-02 2:07 ` Zhang, Yanmin
2009-06-02 11:53 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090527054921.GA4127@localhost.localdomain \
--to=damien.wyart@free.fr \
--cc=akpm@linux-foundation.org \
--cc=chris.mason@oracle.com \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=jens.axboe@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=richard@rsk.demon.co.uk \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).