From mboxrd@z Thu Jan 1 00:00:00 1970 From: Artem Bityutskiy Subject: [PATCH 17/19] VFS: use sb_is_dirty helper Date: Wed, 27 May 2009 16:06:53 +0300 Message-ID: <20090527130653.4913.89984.sendpatchset@localhost.localdomain> References: <20090527130503.4913.62042.sendpatchset@localhost.localdomain> Cc: linux-fsdevel@vger.kernel.org, Christoph Hellwig , Artem Bityutskiy To: linux-kernel@vger.kernel.org Return-path: Received: from smtp.nokia.com ([192.100.122.230]:54728 "EHLO mgw-mx03.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761261AbZE0LNM (ORCPT ); Wed, 27 May 2009 07:13:12 -0400 In-Reply-To: <20090527130503.4913.62042.sendpatchset@localhost.localdomain> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: From: Artem Bityutskiy Subject: [PATCH] VFS: use sb_is_dirty helper ... instead of checking 's_dirt' directly. This is just a little cleaner and more consistent. We have only 3 VFS helpers which access 's_dirt' now. Signed-off-by: Artem Bityutskiy Cc: Christoph Hellwig --- fs/super.c | 4 ++-- fs/sync.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/fs/super.c b/fs/super.c index 2ea1586..ef9a24a 100644 --- a/fs/super.c +++ b/fs/super.c @@ -415,12 +415,12 @@ void sync_supers(void) spin_lock(&sb_lock); restart: list_for_each_entry(sb, &super_blocks, s_list) { - if (sb->s_op->write_super && sb->s_dirt) { + if (sb->s_op->write_super && sb_is_dirty(sb)) { sb->s_count++; spin_unlock(&sb_lock); down_read(&sb->s_umount); - if (sb->s_root && sb->s_dirt) + if (sb->s_root && sb_is_dirty(sb)) sb->s_op->write_super(sb); up_read(&sb->s_umount); diff --git a/fs/sync.c b/fs/sync.c index e9d56f6..12f36d7 100644 --- a/fs/sync.c +++ b/fs/sync.c @@ -33,7 +33,7 @@ static int __sync_filesystem(struct super_block *sb, int wait) else sync_quota_sb(sb, -1); sync_inodes_sb(sb, wait); - if (sb->s_dirt && sb->s_op->write_super) + if (sb_is_dirty(sb) && sb->s_op->write_super) sb->s_op->write_super(sb); if (sb->s_op->sync_fs) sb->s_op->sync_fs(sb, wait); @@ -162,7 +162,7 @@ int file_fsync(struct file *filp, struct dentry *dentry, int datasync) /* sync the superblock to buffers */ sb = inode->i_sb; - if (sb->s_dirt && sb->s_op->write_super) + if (sb_is_dirty(sb) && sb->s_op->write_super) sb->s_op->write_super(sb); /* .. finally sync the buffers to disk */ -- 1.6.0.6