From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 06/13] cifs: add new cifs_iget function and convert unix codepath to use it Date: Wed, 27 May 2009 09:23:32 -0400 Message-ID: <20090527132332.GA5938@infradead.org> References: <1243427434-6498-1-git-send-email-jlayton@redhat.com> <1243427434-6498-7-git-send-email-jlayton@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-cifs-client@lists.samba.org, linux-fsdevel@vger.kernel.org To: Jeff Layton Return-path: Received: from bombadil.infradead.org ([18.85.46.34]:43575 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757603AbZE0NXb (ORCPT ); Wed, 27 May 2009 09:23:31 -0400 Content-Disposition: inline In-Reply-To: <1243427434-6498-7-git-send-email-jlayton@redhat.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, May 27, 2009 at 08:30:27AM -0400, Jeff Layton wrote: > In order to unify some codepaths, introduce a common cifs_fattr struct > for storing inode attributes. The different codepaths (unix, legacy, > normal, etc...) can fill out this struct with inode info. It can then > be passed as an arg to a common set of routines to get and update inodes. > > Add a new cifs_iget function that uses iget5_locked to identify inodes. > This will compare inodes based on the uniqueid value in a cifs_fattr > struct. > > Rather than filling out an already-created inode, have > cifs_get_inode_info_unix instead fill out cifs_fattr and hand that off > to cifs_iget. cifs_iget can then properly look for hardlinked inodes. > > With this, we should then have proper hardlink detection and can > eventually get rid of some nasty CIFS-specific hacks for handing them. > > Fixing the unix readdir codepath will be done in a later patch. Looks good to me: Reviewed-by: Christoph Hellwig