From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH 07/13] cifs: convert posix readdir codepath to use
	cifs_iget
Date: Wed, 27 May 2009 09:36:26 -0400
Message-ID: <20090527133626.GB5938@infradead.org>
References: <1243427434-6498-1-git-send-email-jlayton@redhat.com> <1243427434-6498-8-git-send-email-jlayton@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: linux-cifs-client@lists.samba.org, linux-fsdevel@vger.kernel.org
To: Jeff Layton <jlayton@redhat.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from bombadil.infradead.org ([18.85.46.34]:37366 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932121AbZE0NgY (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Wed, 27 May 2009 09:36:24 -0400
Content-Disposition: inline
In-Reply-To: <1243427434-6498-8-git-send-email-jlayton@redhat.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Wed, May 27, 2009 at 08:30:28AM -0400, Jeff Layton wrote:
> Add a new function that converts FILE_INFO_UNIX to fattr, and a readdir
> lookup function that spawns dentries.

Looks good to me

Reviewed-by: Christoph Hellwig <hch@lst.de>

A bit sad to see the duplicated cifs_unix_basic_to_fattr vs
cifs_unix_info_to_fattr but we can deal with that later.  Maybe at
least move cifs_unix_info_to_fattr into inode.c next to
cifs_unix_basic_to_fattr so that it's more obvious?