From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH 08/13] cifs: convert cifs_get_inode_info to use
	cifs_iget
Date: Wed, 27 May 2009 09:40:43 -0400
Message-ID: <20090527134042.GC5938@infradead.org>
References: <1243427434-6498-1-git-send-email-jlayton@redhat.com> <1243427434-6498-9-git-send-email-jlayton@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: linux-cifs-client@lists.samba.org, linux-fsdevel@vger.kernel.org
To: Jeff Layton <jlayton@redhat.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from bombadil.infradead.org ([18.85.46.34]:41932 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1762291AbZE0Nkl (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Wed, 27 May 2009 09:40:41 -0400
Content-Disposition: inline
In-Reply-To: <1243427434-6498-9-git-send-email-jlayton@redhat.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

Looks good.


Reviewed-by: Christoph Hellwig <hch@lst.de>

Two little nitpicks:

On Wed, May 27, 2009 at 08:30:29AM -0400, Jeff Layton wrote:
>  				access_flags_to_mode(ppace[i]->access_req,
>  						     ppace[i]->type,
> -						     &(inode->i_mode),
> +						     &(fattr->cf_mode),
>  						     &user_mask);
>  			if (compare_sids(&(ppace[i]->sid), pgrpsid))
>  				access_flags_to_mode(ppace[i]->access_req,
>  						     ppace[i]->type,
> -						     &(inode->i_mode),
> +						     &(fattr->cf_mode),
>  						     &group_mask);
>  			if (compare_sids(&(ppace[i]->sid), &sid_everyone))
>  				access_flags_to_mode(ppace[i]->access_req,
>  						     ppace[i]->type,
> -						     &(inode->i_mode),
> +						     &(fattr->cf_mode),
>  						     &other_mask);

If you touch these lines please also remove the superflous braces.

> +	cifs_i->delete_pending = fattr->cf_flags & CIFS_FATTR_DELETE_PENDING;
> +
> +	/*
> +	 * Can't safely change the file size here if the client is writing to
> +	 * it due to potential races.
> +	 */
>  	spin_lock(&inode->i_lock);
>  	if (is_size_safe_to_change(cifs_i, fattr->cf_eof)) {
> -		/*
> -		 * We can not safely change the file size here if the client
> -		 * is writing to it due to potential races.
> -		 */

Why isn't this comment introduced in the correct location in the
patch adding it?