From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: [PATCH 0/12] Per-bdi writeback flusher threads v7 Date: Thu, 28 May 2009 12:20:35 +0200 Message-ID: <20090528102034.GY11363@kernel.dk> References: <20090526164117.GJ11363@kernel.dk> <20090526170845.GA3226@localhost.localdomain> <20090526204703.GM11363@kernel.dk> <20090526211119.GO11363@kernel.dk> <20090527052101.GA28517@localhost.localdomain> <20090527054921.GA4127@localhost.localdomain> <20090527092052.GV11363@kernel.dk> <20090527131555.GA3277@localhost.localdomain> <20090527150546.GM11363@kernel.dk> <20090527140641.71ecaf8c.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: damien.wyart@free.fr, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, chris.mason@oracle.com, david@fromorbit.com, hch@infradead.org, jack@suse.cz, yanmin_zhang@linux.intel.com, richard@rsk.demon.co.uk To: Andrew Morton Return-path: Received: from brick.kernel.dk ([93.163.65.50]:45595 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752430AbZE1KUd (ORCPT ); Thu, 28 May 2009 06:20:33 -0400 Content-Disposition: inline In-Reply-To: <20090527140641.71ecaf8c.akpm@linux-foundation.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, May 27 2009, Andrew Morton wrote: > On Wed, 27 May 2009 17:05:47 +0200 > Jens Axboe wrote: > > > I ran testing with artificial > > bdi_work allocation failures to verify the oom path > > I bet you didn't use lib/fault-inject.c :( I didn't, it was a 2-second hack to add a static int i; if (!(i++ % 4)) return NULL; so I didn't look further... > For tricky pieces of core kernel like this, there's a good case for > including and permanently maintaining fault injection testing > capabilities. I agree. -- Jens Axboe