From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Piggin Subject: Re: Why do fs outside regular namespace clear DCACHE_UNHASHED? Date: Mon, 1 Jun 2009 13:23:15 +0200 Message-ID: <20090601112315.GC5018@wotan.suse.de> References: <20090528071441.GE6920@wotan.suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org To: Miklos Szeredi Return-path: Received: from cantor2.suse.de ([195.135.220.15]:59734 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755859AbZFALXO (ORCPT ); Mon, 1 Jun 2009 07:23:14 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, May 28, 2009 at 01:43:40PM +0200, Miklos Szeredi wrote: > On Thu, 28 May 2009, Nick Piggin wrote: > > Please humour a relative vfs/procfs newbie... Why do filesystems insist that > > a dentry must be !DCACHE_UNHASHED in order to work in /proc/pid/fd/? I can't > > find the code that checks this, and pipefs fds for example _seems_ to work in > > proc/pid with this patch applied... > > I suspect this is more of an optimization: the old code tries not to > burden the global dentry cache with all the anonymous pipes, sockets, > etc. since they won't ever be looked up from the cache. But I also couldn't see that the flag causes the dcache to put the entry in the hash or not...