From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: [PATCH 0/11] Per-bdi writeback flusher threads v9 Date: Wed, 3 Jun 2009 10:07:41 +0200 Message-ID: <20090603080741.GE11363@kernel.dk> References: <4A1E9D0B.4090402@gmail.com> <4A1E9D8B.8020908@gmail.com> <1243542908.6645.104.camel@laptop> <4A20011E.7020900@nokia.com> <20090529155046.GH11363@kernel.dk> <4A20072B.7050807@nokia.com> <20090529170742.GI11363@kernel.dk> <4A2628A7.9080407@nokia.com> <20090603074417.GC11363@kernel.dk> <4A262D6E.9070908@nokia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Peter Zijlstra , "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "tytso@mit.edu" , "chris.mason@oracle.com" , "david@fromorbit.com" , "hch@infradead.org" , "akpm@linux-foundation.org" , "jack@suse.cz" , "yanmin_zhang@linux.intel.com" , "richard@rsk.demon.co.uk" , "damien.wyart@free.fr" To: Artem Bityutskiy Return-path: Received: from brick.kernel.dk ([93.163.65.50]:57567 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756317AbZFCIHk (ORCPT ); Wed, 3 Jun 2009 04:07:40 -0400 Content-Disposition: inline In-Reply-To: <4A262D6E.9070908@nokia.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, Jun 03 2009, Artem Bityutskiy wrote: > Jens Axboe wrote: >>> Just to make sure I understood you correctly. I assume my original >>> patch is fine (because there is bdi_destroy()) and merge it to >>> ubifs tree. >> >> It needs to be: >> >> err = bdi_register(&c->bdi, NULL, "ubifs"); >> if (err) >> goto out_bdi; >> >> so you hit the bdi_destroy() for that failure, not goto out_close; >> Otherwise it was fine. > > Did this, also added a > Reviewed-by: Jens Axboe > > http://git.infradead.org/ubifs-2.6.git?a=commit;h=813fdc16ad591e79d0c1b88d31970dcd1c2aa3f1 Looks good! -- Jens Axboe