From: Christoph Hellwig <hch@lst.de>
To: viro@zeniv.linux.org.uk
Cc: linux-fsdevel@vger.kernel.org
Subject: [PATCH 7/12] hfsplus: add ->sync_fs
Date: Mon, 8 Jun 2009 10:05:12 +0200 [thread overview]
Message-ID: <20090608080512.GH20735@lst.de> (raw)
In-Reply-To: <20090608080252.GA20735@lst.de>
Add a ->sync_fs method for data integrity syncs, and reimplement
->write_super ontop of it.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: vfs-2.6/fs/hfsplus/super.c
===================================================================
--- vfs-2.6.orig/fs/hfsplus/super.c 2009-06-05 16:17:32.048939821 +0200
+++ vfs-2.6/fs/hfsplus/super.c 2009-06-05 16:19:06.525940458 +0200
@@ -152,7 +152,7 @@ static void hfsplus_clear_inode(struct i
}
}
-static void hfsplus_write_super(struct super_block *sb)
+static int hfsplus_sync_fs(struct super_block *sb, int wait)
{
struct hfsplus_vh *vhdr = HFSPLUS_SB(sb).s_vhdr;
@@ -160,9 +160,6 @@ static void hfsplus_write_super(struct s
lock_super(sb);
sb->s_dirt = 0;
- if (sb->s_flags & MS_RDONLY)
- /* warn? */
- goto out;
vhdr->free_blocks = cpu_to_be32(HFSPLUS_SB(sb).free_blocks);
vhdr->next_alloc = cpu_to_be32(HFSPLUS_SB(sb).next_alloc);
@@ -194,8 +191,16 @@ static void hfsplus_write_super(struct s
}
HFSPLUS_SB(sb).flags &= ~HFSPLUS_SB_WRITEBACKUP;
}
- out:
unlock_super(sb);
+ return 0;
+}
+
+static void hfsplus_write_super(struct super_block *sb)
+{
+ if (!(sb->s_flags & MS_RDONLY))
+ hfsplus_sync_fs(sb, 1);
+ else
+ sb->s_dirt = 0;
}
static void hfsplus_put_super(struct super_block *sb)
@@ -290,6 +295,7 @@ static const struct super_operations hfs
.clear_inode = hfsplus_clear_inode,
.put_super = hfsplus_put_super,
.write_super = hfsplus_write_super,
+ .sync_fs = hfsplus_sync_fs,
.statfs = hfsplus_statfs,
.remount_fs = hfsplus_remount,
.show_options = hfsplus_show_options,
next prev parent reply other threads:[~2009-06-08 8:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-08 8:02 [PATCH 0/12] make ->sync_fs mandatory Christoph Hellwig
2009-06-08 8:03 ` [PATCH 1/12] affs: add ->sync_fs Christoph Hellwig
2009-06-08 8:03 ` [PATCH 2/12] bfs: " Christoph Hellwig
2009-06-08 8:03 ` [PATCH 3/12] exofs: " Christoph Hellwig
2009-06-09 13:03 ` Boaz Harrosh
2009-06-08 8:04 ` [PATCH 4/12] ext2: " Christoph Hellwig
2009-06-08 8:04 ` [PATCH 0/12] make ->sync_fs mandatory Christoph Hellwig
2009-06-08 8:04 ` [PATCH 6/12] hfs: add ->sync_fs Christoph Hellwig
2009-06-08 8:05 ` Christoph Hellwig [this message]
2009-06-08 8:07 ` [PATCH 8/12] sysv: " Christoph Hellwig
2009-06-08 8:08 ` [PATCH 9/12] ufs: " Christoph Hellwig
2009-06-08 8:08 ` [PATCH 10/12] jffs2: call jffs2_write_super from jffs2_sync_fs Christoph Hellwig
2009-06-08 8:08 ` [PATCH 11/12] nilfs2: call nilfs2_write_super from nilfs2_sync_fs Christoph Hellwig
2009-06-08 8:08 ` [PATCH 12/12] remove the call to ->write_super in __sync_filesystem Christoph Hellwig
2009-06-08 14:45 ` [PATCH 0/12] make ->sync_fs mandatory Al Viro
2009-06-09 12:55 ` Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090608080512.GH20735@lst.de \
--to=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).