From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: [PATCH 12/12] remove the call to ->write_super in __sync_filesystem Date: Mon, 8 Jun 2009 10:08:54 +0200 Message-ID: <20090608080854.GM20735@lst.de> References: <20090608080252.GA20735@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org To: viro@zeniv.linux.org.uk Return-path: Received: from verein.lst.de ([213.95.11.210]:33459 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754376AbZFHIIx (ORCPT ); Mon, 8 Jun 2009 04:08:53 -0400 Content-Disposition: inline In-Reply-To: <20090608080252.GA20735@lst.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Now that all filesystems provide ->sync_fs methods we can change __sync_filesystem to only call ->sync_fs. This gives us a clear separation between periodic writeouts which are driven by ->write_super and data integrity syncs that go through ->sync_fs. (modulo file_fsync which is also going away) Signed-off-by: Christoph Hellwig Index: vfs-2.6/fs/sync.c =================================================================== --- vfs-2.6.orig/fs/sync.c 2009-06-05 16:29:58.691814461 +0200 +++ vfs-2.6/fs/sync.c 2009-06-05 16:31:13.702939647 +0200 @@ -33,8 +33,6 @@ static int __sync_filesystem(struct supe else sync_quota_sb(sb, -1); sync_inodes_sb(sb, wait); - if (sb->s_dirt && sb->s_op->write_super) - sb->s_op->write_super(sb); if (sb->s_op->sync_fs) sb->s_op->sync_fs(sb, wait); return __sync_blockdev(sb->s_bdev, wait);