From: Al Viro <viro@ZenIV.linux.org.uk>
To: pravin shelar <Pravin.Shelar@Sun.COM>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: [patch] add dentry revalidate to follow mount.
Date: Mon, 8 Jun 2009 21:17:45 +0100 [thread overview]
Message-ID: <20090608201745.GO8633@ZenIV.linux.org.uk> (raw)
In-Reply-To: <4A2D735C.8090703@sun.com>
On Tue, Jun 09, 2009 at 01:53:56AM +0530, pravin shelar wrote:
> Al Viro wrote:
>> On Mon, Jun 08, 2009 at 07:14:15PM +0530, pravin shelar wrote:
>>> Hi
>>> i have seen error in lustre while setting permission on fs root
>>> from a client. problem is permission are not getting propagated to
>>> other clients.
>>>
>>> this is because of do_lookup() call path which does not revalidate
>>> fs root dentry in follow_mount()
>>>
>>> attached patch adds revalidation call in follow_mount.
>>
>> ... and makes umount() of such thing impossible. NAK. That's not a solution.
>
> i am not sure how this patch could cause problem for umount. i have
> tested patch with nfs and it worked fine.
> can u elaborate what is problem?
Think what happens if revalidate fails and keeps failing. Would do
wonders to pathname resolution in umount(2)...
next prev parent reply other threads:[~2009-06-08 20:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-08 13:44 [patch] add dentry revalidate to follow mount pravin shelar
2009-06-08 14:13 ` Al Viro
2009-06-08 20:23 ` pravin shelar
2009-06-08 20:17 ` Al Viro [this message]
2009-06-09 3:43 ` Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090608201745.GO8633@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=Pravin.Shelar@Sun.COM \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).