From: Al Viro <viro@ZenIV.linux.org.uk>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-next@vger.kernel.org, Theodore Ts'o <tytso@mit.edu>,
linux-fsdevel@vger.kernel.org
Subject: Re: linux-next: next-20090609 hangs in early user mode
Date: Wed, 10 Jun 2009 14:00:54 +0100 [thread overview]
Message-ID: <20090610130054.GR8633@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20090610180058.99bd3dda.sfr@canb.auug.org.au>
On Wed, Jun 10, 2009 at 06:00:58PM +1000, Stephen Rothwell wrote:
> d4fdcb2068eef29c03d6027aa219fa60171c6b87 is first bad commit
> commit d4fdcb2068eef29c03d6027aa219fa60171c6b87
> Author: Theodore Ts'o <tytso@mit.edu>
> Date: Thu May 21 16:00:59 2009 -0400
>
> fs: i_flags and i_state in struct inode only need to be unsigned short
>
> Currently i_flags and i_state do not need to be an unsigned int and an
> unsigned long, respectively. (We currently use 9 i_flags bits, and 8
> i_state bits.) Changing them to be an unsigned short saves 4 bytes
> per inode on an x86 platform, and 8 bytes on an x86_64 platform.
>
> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
> Cc: linux-fsdevel@vger.kernel.org
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
*gyah*
Yes, it's obviously bogus. Dropped from the tree; I don't think it's
really salvagable - even merging into one unsigned long will not be
enough, since we will end up with different locking for different bits.
next prev parent reply other threads:[~2009-06-10 13:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-10 8:00 linux-next: next-20090609 hangs in early user mode Stephen Rothwell
2009-06-10 8:31 ` Christoph Hellwig
2009-06-10 8:44 ` Stephen Rothwell
2009-06-10 8:46 ` Stephen Rothwell
2009-06-10 13:00 ` Al Viro [this message]
2009-06-10 13:07 ` Stephen Rothwell
2009-06-10 13:19 ` Theodore Tso
2009-06-10 15:08 ` Al Viro
2009-06-10 16:09 ` Theodore Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090610130054.GR8633@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).